Remove ogr2ogr dependency #50

Closed
gravitystorm opened this Issue May 18, 2013 · 9 comments

Comments

Projects
None yet
5 participants
@gravitystorm
Owner

gravitystorm commented May 18, 2013

Given that we only need it for one minor task, we should remove the ogr2ogr dependency from the setup. It's not too bad on linux systems (yay package management) but it's an unnecessary hurdle elsewhere.

If we can't get the NE shapefile fixed upstream, then lets host a fixed version of the file somewhere and grab it from there instead.

@pnorman

This comment has been minimized.

Show comment Hide comment
@pnorman

pnorman May 28, 2013

Collaborator

This was fixed in mapnik/mapnik#1605 (comment) but we'd have to bump the required version to 2.2, which hasn't yet been released.

This would also impact #45 but because ogr2ogr is warning about encodings we should check that the rendered result gets it right before dropping ogr2ogr.

Hosting a fixed version would of course render the issue moot

Collaborator

pnorman commented May 28, 2013

This was fixed in mapnik/mapnik#1605 (comment) but we'd have to bump the required version to 2.2, which hasn't yet been released.

This would also impact #45 but because ogr2ogr is warning about encodings we should check that the rendered result gets it right before dropping ogr2ogr.

Hosting a fixed version would of course render the issue moot

@pnorman

This comment has been minimized.

Show comment Hide comment
@pnorman

pnorman Jun 10, 2013

Collaborator

If hosting a fixed version we should strip out unnecessary shapefile fields to save space. Have we contacted NE to ask about getting them to fix the issues?

Collaborator

pnorman commented Jun 10, 2013

If hosting a fixed version we should strip out unnecessary shapefile fields to save space. Have we contacted NE to ask about getting them to fix the issues?

@springmeyer

This comment has been minimized.

Show comment Hide comment
@springmeyer

springmeyer Aug 7, 2013

Contributor

@pnorman, natural earth maintainer was hired by apple, so "we" are all natural earth maintainers now.

Contributor

springmeyer commented Aug 7, 2013

@pnorman, natural earth maintainer was hired by apple, so "we" are all natural earth maintainers now.

@pnorman

This comment has been minimized.

Show comment Hide comment
@pnorman

pnorman Aug 13, 2013

Collaborator

Created a NaturalEarth Correction ticket (UA3125RX4Z) as that seems to be the only way on their site. If we get no response, I guess we'll have to look at hosting a fixed version on planet.osm.org or somewhere?

Collaborator

pnorman commented Aug 13, 2013

Created a NaturalEarth Correction ticket (UA3125RX4Z) as that seems to be the only way on their site. If we get no response, I guess we'll have to look at hosting a fixed version on planet.osm.org or somewhere?

@tomhughes

This comment has been minimized.

Show comment Hide comment
@tomhughes

tomhughes Aug 20, 2013

@pnorman if mapnik 2.2 is fixed does that mean we can skip the ogr2ogr step on the production servers which are using 2.2?

@pnorman if mapnik 2.2 is fixed does that mean we can skip the ogr2ogr step on the production servers which are using 2.2?

@pnorman

This comment has been minimized.

Show comment Hide comment
@pnorman

pnorman Aug 20, 2013

Collaborator

My reading of git is that mapnik/mapnik@913e1d0 is in 2.2.0 but I'm not 100% confident.

Also I haven't tested.

So almost certainly, but a slim chance of a problem.

Collaborator

pnorman commented Aug 20, 2013

My reading of git is that mapnik/mapnik@913e1d0 is in 2.2.0 but I'm not 100% confident.

Also I haven't tested.

So almost certainly, but a slim chance of a problem.

@tomhughes

This comment has been minimized.

Show comment Hide comment
@tomhughes

tomhughes Aug 20, 2013

That commit is in 2.2.0 yes.

That commit is in 2.2.0 yes.

@pnorman

This comment has been minimized.

Show comment Hide comment
@pnorman

pnorman Aug 21, 2013

Collaborator

If we can't get the NE shapefile fixed upstream, then lets host a fixed version of the file somewhere and grab it from there instead.

Well, since this seems to not be an option, how about hosting a fixed one on planet.osm.org? I know it's not ideal, but neither is requiring ogr2ogr or mapnik 2.2.

On the other hand, if andy is planning on introducing features that require mapnik 2.2 then we can drop ogr2ogr when the minimum mapnik version is upgraded

Collaborator

pnorman commented Aug 21, 2013

If we can't get the NE shapefile fixed upstream, then lets host a fixed version of the file somewhere and grab it from there instead.

Well, since this seems to not be an option, how about hosting a fixed one on planet.osm.org? I know it's not ideal, but neither is requiring ogr2ogr or mapnik 2.2.

On the other hand, if andy is planning on introducing features that require mapnik 2.2 then we can drop ogr2ogr when the minimum mapnik version is upgraded

@pnorman

This comment has been minimized.

Show comment Hide comment
@pnorman

pnorman Sep 29, 2013

Collaborator

One other option is to use mapnik-config -v to identify if we have mapnik 2.2.0 or later and if so, skip ogr2ogr.

Collaborator

pnorman commented Sep 29, 2013

One other option is to use mapnik-config -v to identify if we have mapnik 2.2.0 or later and if so, skip ogr2ogr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment