Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

line-color should be related to polygon-fill for most if not all polygon features #57

Closed
ian29 opened this Issue · 11 comments

5 participants

@ian29

This would simplify both the visual style and the code base considerably. Ideally we do this by establishing a convention like

polygon-fill: @some_color;
line-color: darken(@some_color, 10%)

although I imagine there will need to be considerable tweaking

@math1985 math1985 added roads landcover and removed roads labels
@math1985
Collaborator

@floscher is this issue solved, or is there more that needs to be done?

@math1985 math1985 added this to the Bugs and improvements milestone
@math1985
Collaborator

This has been resolved in the meanwhile.

@math1985
Collaborator

Why you think they are not related? They have the same hue, at least.

@matkoniecz
Collaborator

I think that these are related, that is why this ticket applies to them and is not fixed (I replied to "This has been resolved in the meanwhile.")

@math1985
Collaborator

I don't follow you. If color and fill are related, the issue is solved, isn't it?

@matkoniecz
Collaborator

I thought that replacing direct color definitions by darken(@color, something%) was part of this ticket ("Ideally we do this by").

I also think that it is a good idea, as it makes later changes of colours easier.

@math1985
Collaborator

Darken works on rgb, here basically the same has been done in Lch. I think Lch is preferable, even though Carto does not support it natively.

@matkoniecz
Collaborator

OK, so with this part rejected I also think that this is solved.

@matkoniecz matkoniecz closed this
@HolgerJeromin

I think Lch is preferable, even though Carto does not support it natively.

which is btw issue:
mapbox/carto#354

@pnorman
Collaborator

Yes - the basic problem with darken(@color, something%) is that it not only darkens, but also changes the perceptual hue and chroma. With the old colours, that's not too serious an issue because they were chosen sloppily enough, but when you're working out all the colours in a perceptual colour space, it makes sense to do them all there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.