Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sport icons #844

Open
matthijsmelissen opened this Issue Aug 5, 2014 · 71 comments

Comments

Projects
None yet
@matthijsmelissen
Copy link
Collaborator

commented Aug 5, 2014

Currently all sport fields are shown in the same style. It is very difficult to distinguish the different sports. Furthermore there are good sport icon sets out there: http://wiki.openstreetmap.org/wiki/Category:Sport_icon Comparing the different olympic pictograms http://www.nytimes.com/interactive/2010/02/24/sports/olympics/pictograms-interactive.html I suggest to take the icon sets of Olympic games 1972 (munich) http://olympic-museum.de/pictograms/Picto1972.htm adopted to the constraints of 16px

See also https://trac.openstreetmap.org/ticket/3159.

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2014

For some sport (basketball, football, rugby, soccer, tennis) there are working line renderings available. This link show soccer and tennis lines:

http://tile.openstreetmap.fr/?zoom=19&lat=50.77898&lon=6.0707&layers=B0000000FFFFFFF

The code is here:
https://github.com/cquest/osmfr-cartocss

@polarbearing

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2014

The line rendering itself is fine and self-explanatory, though I would prefer not to add plenty new colours to the main map.

@Rovastar

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2014

I think a longer term goal (no pun intended) is for the osm fr style.

Icons might be nice but most of the well known ones will be copyrighted/trademarked.

@Rovastar

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2014

Oh meant to say the line style is for v3.x as it will require adding new stuff to the database.

@boothym

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2016

How about adding icons for the most used sports to begin with? Soccer, tennis, baseball, basketball, all have good icons that can be used from iD editor's icon set. Just like iD the icon can be put in the middle of the pitch.

https://github.com/bhousel/maki/blob/mb-pages/src/soccer-24.svg
https://github.com/bhousel/maki/blob/mb-pages/src/tennis-24.svg
https://github.com/bhousel/maki/blob/mb-pages/src/baseball-24.svg
https://github.com/bhousel/maki/blob/mb-pages/src/basketball-24.svg

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2016

Unfortunately they all are 24px, while we use just 14px - this is huge difference. If you want to see how they would look in this style, try to rescale them and save as PNG.

@boothym

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2016

I linked to them because I thought you'd want the largest svg size available, but here's what they look like at 14px:
tennis
soccer
baseball
basketball

There's also https://github.com/mapbox/maki/tree/master/icons with more stick figures instead of the bat/ball icons.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2016

I'm surprised, they look quite nice and are perfectly recognizable! That's the power of skilled designer probably. =}

Still we need to decide if we want to use icons or field markings.

@Wuzzy2

This comment has been minimized.

Copy link

commented Sep 30, 2016

I'm very strongly for icons. Field markings are poorly recognizable and potentionally ambigious. Also, the field markings are not actually based on OSM data so they are basically lies, stricly spoken. The real field markings might either not exist at all or they are just wrong.
For example, not all soccer fields actually have field markings, especially small ones. Also, the field markings will be hard to be understood for people not knowing a particular sport very well.
Also, field markings do not fit into the “tradition” of the default OSM style of only showing what's actually there in the data, rather than “interpreting” stuff into the data which simply isn't there.

On the other hand, icons are WAY more recognizable, even by people not knowing awfully much about the sport. Also, the default style already uses icons for everything, so this just seems consequent. :-)

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2016

For example, not all soccer fields actually have field markings, especially small ones.

Maps are no rendered satellite images.

Also, the field markings will be hard to be understood for people not knowing a particular sport very well.
On the other hand, icons are WAY more recognizable, even by people not knowing awfully much about the sport.

As an counter example there are many racket sports. I am not sure which is meant by the tennis icon from boothym. But the line marking is pretty unique.

Also, field markings do not fit into the “tradition” of the default OSM style of only showing what's actually there in the data, rather than “interpreting” stuff into the data which simply isn't there.

Think of the markings as a big icon :-P

@Wuzzy2

This comment has been minimized.

Copy link

commented Sep 30, 2016

For example, not all soccer fields actually have field markings, especially small ones.

Maps are no rendered satellite images.

Exactly. And I think field markings try way too hard to look “authentic”. Under the same logic, OSM could attempt to draw road markings on roads. I know, I know, field markings look cool, but they are not exactly useful for a map when you actually want to read information from it.
Icons are more abstract, therefore a more logical choice for a map.

As an counter example there are many racket sports. I am not sure which is meant by the tennis icon from boothym. But the line marking is pretty unique.

I guess the tennis icon stands for “tennis”. ;-) You already said “tennis” by yourselves! xD Also because this is probably the most well-known one.
Yes, it's probably hard to draw an icon for every sport in existance but OSM could just start with the most common ones while adding icons later. Sports without an icon could maybe get a generic icon or no icon.

The homepage really should improve its map key because the default style has so many different icons, but almost no icon is actually explained. :-( In fact, the map key is very, VERY incomplete (sadly).
Creating a key for the icons would (hopefully) not be too hard (it just needs to be done).
But creating a key for the markings or all sport pitches would be overkill and therefore it would be pretty unlikely to happen. I fear that Average Joe will fail to recognize the lion's share of possible sport pitches.

Think of the markings as a big icon :-P

Pfff, this is weak. The markings are nothing like icons. Icons are not rotated and have a fixed size and are always put on a point. Markings can be rotated, are made of lines and differ in size and take an area.

@boothym

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2016

As an counter example there are many racket sports. I am not sure which is meant by the tennis icon from boothym. But the line marking is pretty unique.

Other racket sports have slightly different rackets (e.g. longer handle in badminton) and most of them are played indoors. If you see a pitch in OSM with a racket and ball, and it's not inside a building it's highly likely to be tennis (given 230,000 courts have been mapped!).

Anyway, the main thing is that I think icons should be added as soon as possible for the most important sports in OSM. They presumably are easier to add than markings and would definitely improve the map styling.

@boothym

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2016

Is someone able to render these so we can see what they look like? @kocio-pl ?

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Oct 6, 2016

What should the colors be (re)used then?

I hope pitch color will be made less dominant soon, but green symbols with green label could be hardly readable.

@boothym

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2016

I was thinking basically how they are just now - dark gray/black (with transparency)?

@Hufkratzer

This comment has been minimized.

Copy link

commented Feb 1, 2017

Can you please also add an icon for riding arenas (tagged leisure=pitch + sport=equestrian 🐴) ?

The taginfo statistics for leisure=pitch + sport=* is:
soccer; 276k
tennis: 234k
baseball: 91k
basketball: 76k
multi: 32k
golf: 23k (but golf courses shall not be tagged as pitches)
equestrian: 15k 🐴
volleyball: 12k
athletics: 7k

The icon may be:
a) horse shoe
b) horse head 🐴 <- github horse head
c) horse without rider
d) horse with rider 🏇 <- github horse rider

For a) and b) here are two possibilities shown together with the other icons:
hshoe-14 from http://publicdomainvectors.org/en/free-clipart/Horseshoe-silhouette-vector-graphics/14822.html
hhead14-1 from https://commons.wikimedia.org/wiki/File:1_Cav_Shoulder_Insignia.svg
mysoccer-14 from https://github.com/bhousel/maki/blob/mb-pages/src/soccer-24.svg
mytennis-14 from https://github.com/bhousel/maki/blob/mb-pages/src/tennis-24.svg
mybaseball-14 from https://github.com/bhousel/maki/blob/mb-pages/src/baseball-24.svg
mybasketball-14 from https://github.com/bhousel/maki/blob/mb-pages/src/basketball-24.svg

For c) and d) I was not able yet to produce a good looking 14px png export from any of the free svg sources I have found. Perhaps my fault, I am not an experienced icon designer. But I nevertheless wanted to submit this request already. Here are some horse icons:

Also please take into account that pitches can be indoors (in a hall or under a roof), in these cases markings can not be used, but icons probably can.

@imagico

This comment has been minimized.

Copy link
Collaborator

commented Feb 1, 2017

We would need to be careful here because it might not be clear what feature the icon applies to, i.e. the pitch itself or the facility the pitch is part of.

Also note the horse as a symbol - no matter if with a rider or not - can mean a lot of different things and does not necessarily imply something sport related.

@Hufkratzer

This comment has been minimized.

Copy link

commented Feb 1, 2017

Not every riding arena (equestrian pitch) is part of a riding facility or anything similar, like also not every other kind of pitch is part of a sports centre, leisure park or so. Especially in these cases it would be helpful if the map would show what kind of pitch it is.

I agree that it would be good if the icon would look related to equestrian sports, perhaps a jumping horse, but I don't know if that can be done in a 14px icon.

@boothym

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

@kocio-pl I know I've asked before but any chance the icons I posted could be rendered?

I noticed there is a 0.3 opacity white outline to the black icon in the svg which I had to remove first.
Preview I created in photoshop:
tennis

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Nov 13, 2017

Sorry, I'm currently busy with many other problems, which I think are more important.

It's not clear what people would decide, but the best chances would be to create 14 px versions of icons (leisure green is probably better than black - and we already have golf icon), create the code, test them and make a PR with renderings. Could you try to do it?

@Tomasz-W

This comment has been minimized.

Copy link

commented Jul 11, 2018

I was looking at Taginfo sport=* key list to choose which tags can have an special icon in combination with leisure=sport_centre / leisure=pitch . It's very interesting, beacuse there are some sports which I even didn't hear about earlier (eg. netball or gaelic games), more popular than eg. boxing or car racing. I think we should prepare a list of sport=* tags which we want special icon for, and for the rest use just generic leisure-green dot for leisure=sports_centre (see: #2930) and current "blank" leisure=pitch rendering.

Which sport centres and pitches you would like to see with a special icon?

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2018

Line markings are still not rejected #1126

@Hufkratzer

This comment has been minimized.

Copy link

commented Jul 30, 2018

First I thought that there could be a problem with too many icons if many table_tennis tables are near together like here:
table_tennis
(https://www.openstreetmap.org/way/302613825)

But then I saw that for other objects like picnic_tables and benches this problem seems to have been solved, see here:
picnic_tables
(http://www.openstreetmap.org/node/1894660341 in iD;
the small icons are from iD, the bigger ones (less) from carto).

I wonder why this kind of solution wasn't/isn't applicable for swimming_pool's (#2870).

@Tomasz-W

This comment has been minimized.

Copy link

commented Aug 3, 2018

@Hufkratzer

This comment has been minimized.

Copy link

commented Oct 12, 2018

What about sport=horse_racing on leisure=track?

Wiki:

sport=horse_racing has > 2k uses just on tracks which is more than scuba_diving, canoe / rowing and billiards.each have in total and these tracks for horse_racing are quite large objects.

Examples:

Icon could be something like
racingb14 (just a rough draft)
(🏇 <- github horse_racing icon)

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

(🏇 <- github horse_racing icon)

No, this is the horse racing icon of your browser/ operating system (list).
Win 10 is quite colorful for example:
image

@Adamant36

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

@Hufkratzer, I think we could render a horse racing icon sports centers that have the sport=horse_racing tag. I don't don't recommend it on on tracks though due to the current issues we have with icons positions not rendering well if the area is round etc. Otherwise, it will render it will render in the middle or some other weird spot. If I remember correctly it was an issue on the Maptnik side that was supposedly fixed, but I've still been seeing it around sometimes. Its been a while though.

@Hufkratzer

This comment has been minimized.

Copy link

commented Oct 15, 2018

I think most tracks (running, athletics, horse_racing, skateboarding, also motorsport tracks (highway=raceway's)) are currently not in sports_centre's, examples https://www.openstreetmap.org/way/192989911
https://www.openstreetmap.org/relation/6154664
If you render icons for leisure=sports_centre instead of leisure=track you will somehow force mappers to map sports_centre's where no sports_centre's are (or to nest sports_centre's) if they want the sport specific icons on the map. Is that desirable?

Also leisure=stadium has no icon; if you render sports_centre with an icon and stadium not, you may encourage mappers to retag stadium's with leisure=sports_centre; is that desirable? Examples:
https://www.openstreetmap.org/way/258815225
https://www.openstreetmap.org/relation/8129847
https://www.openstreetmap.org/way/146537002.

I can imagine that the placement of an icon may often be more complicated for tracks than for pitches or for sports_centre's, but If it's just a mapnik bug that hinders you to render icons for tracks, it may be better to wait until this bug is fixed, rather than to do it for sports_centre's instead. But when I look at this sports_centre it seems that the placement of icons works quite well:
https://www.openstreetmap.org/relation/8695416

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

If I remember correctly it was an issue on the Mapnik side that was supposedly fixed, but I've still been seeing it around sometimes. Its been a while though.

@Adamant36
This was #2457 and is fixed and deployed. https://www.openstreetmap.org/way/96821031#map=19/50.76494/6.07436

@Adamant36

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

Woho, I finally got the code for sports icons working. So expect some test renderings any day now. This ones been on the top of my list for a while now.
baseball

@Adamant36

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2018

Maki versus Tomasz-W icons. If people don't mind I think I'll do a PR for the main sports just to get to it implement and do the rest later. Since there's like 16 of them and it will take a lot more time otherwise.

Maki baseball
baseball maki
Tomasz-W baseball
baseball tomasz
Maki basketball
basketball maki
Tomasz-W basketball
basketball tomasz
Maki soccer
soccer maki
Tomasz-W soccer
soccer tomasz
Maki tennis
tennis maki
Tomasz-W tennis
tennis tomasz
Personally, I'm leaning more toward Tomasz-W's icons because they aren't mostly solid black. So they don't stand out as much.

@Tomasz-W

This comment has been minimized.

Copy link

commented Nov 20, 2018

@Adamant36 In combination with leisure=pitch icons should be man-made-grey (and in combination with leisure=sports_centre leisure-green)

@Adamant36

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

@Tomasz-W How come you think they should be man-made-grey for pitches? Last time I checked names on pitches are currently rendered in green. Plus its a leisure tag. Eveeything else leisure is green. Also, I'm not dealing with sports centers at this point. I want to figure out the icons were using and get pitches implimented first.

@Tomasz-W

This comment has been minimized.

Copy link

commented Nov 21, 2018

@Adamant36 Imagine a big soccer training centre - if we would render both pitches and sports centres icons in leisure green, there will be just a chaotic bunch of green balls around, in my vision there would be man-made-grey pitches and green ball icon in sports centre middle. It was actually proposed initially: #844 (comment), so it's nothing new. Another thing is that for single objects we should use man-made-gray and for more complicated ones leisure-green. I know this ticket is about piches but we have to think long-term.

@meased

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

I think #844 (comment) was just a lazy photoshop example, not a request to use black icons. I find grey icons quite odd as I can't see how something like "baseball" would be categorized as "generic" and not "leisure".

Could you explain your vision a little better? Perhaps a mockup?

@geostonemarten

This comment has been minimized.

Copy link

commented Nov 21, 2018

And what about multi or comma separated value. In your case you don't add name but I have lot of example with complexe name and sub parts with pitch name

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Nov 21, 2018

I would try with sport icons for pitches rendered as green, but stadiums or other bigger sport entities with a reversed white icon on a green background - something like we do with bus stops and bus stations:

bus station

@geostonemarten

This comment has been minimized.

Copy link

commented Nov 21, 2018

I would try with sport icons for pitches rendered as green, but stadiums or other bigger sport entities with a reversed white icon on a green background - something like we do with bus stops and bus stations:

bus station

Why??? that is not the case for all other icons in openstreetmap carto ...

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

commented Nov 21, 2018

Because this way we would keep the color for pitches while at the same time indicating that they are special (bigger).

@boothym

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

@Adamant36 agreed, though my only concern with the Tomasz-W icons is the basketball being too similar to the soccer ball?

Do you mind rendering a pitch which has a name as well as a sport?

@Tomasz-W my image further up the thread was just a quick photoshop to try and get some progress on this issue (first comment in 9 months!) 😉 I'd go for green now that I've seen it rendered.

As for a big soccer training centre - it would be good to have some example renderings of both pitches and sports centres with sport=*:

@Adamant36

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2018

So, green for the icons it is then.........Any feedback besides @boothym's on which set of icons are better?

@boothym, they do kind of look similar. I'm willing to go with Maki's soccer ball, if there is wider agreement.

Also, as I said above, I'm not doing sports centers until pitches get done and rendered. Its a lot less complicated that way and it has a better chance of not getting derailed before it gets merged.

Plus, we haven't even figured out the icons we are going with yet anyway. So, its kind of putting the cart before the horse.

If there's a problem with that, someone else is free to work on the issue.

@Tomasz-W

This comment has been minimized.

Copy link

commented Nov 29, 2018

My picks of icons after test renderings:

  • baseball -> Tomasz-W
  • basketball -> 50/50
  • soccer -> Tomasz-W
  • tennis -> Tomasz-W

@Adamant36 Anyway, I hope you will make tests of example places linked above in both versions (e.g. with simple green dot-rendering for sports centres) to compare and make a fair decision ;)

@Adamant36

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2018

@Tomasz-W, OK.

I will eventually after pitches get done. Rendering on sports centers doesn't really affect how or what's rendered on pitches at this point though. Plus, The green dot-rendering is a different issue. It will get done at some point in its own PR.

@Adamant36

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2018

@Tomasz-W, btw, do you know of any sports centers tagged as one sport that contains pitches from another sport? Also, it seems like it would be a little redundant to have an icon for a sports center along with all the pitches there. It should be clear from the pitches what kind of sports center it is. Plus, they might block each other out.

P.S. Can you make icons for roller skating and ice skating? They both have numbers around 1000 each, but I feel like they could be added anyway. Since there probably aren't many places for them in the world anyway.

@Hufkratzer

This comment has been minimized.

Copy link

commented Nov 29, 2018

my only concern with the Tomasz-W icons is the basketball being too similar to the soccer ball?

The maki basketball icon is hard to recongnize, therefore I would prefer the ball icon for basketball.

What about something like mybb14? This is from https://commons.wikimedia.org/wiki/File:Font_Awesome_5_solid_basketball-ball.svg,
not free, would have to be redrawn.

@boothym

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

@Adamant36 I was actually thinking the other way around - use Maki's basketball with the backboard, and Tomasz-W's soccer ball.

@IgorEliezer

This comment has been minimized.

Copy link

commented Apr 10, 2019

Hello,

If having so many icons is an issue (#3651) or having field marking is too much (#1126), why don't you people reuse the leisure=fitness_station icon to represent all ground sports since most of them involve running or at least moving on a field?

I think having to distinguish a sport field from the rest of the map is more of an issue than distinguishing the fields from each other.

It would at least reduce the need of using generic names like "Soccer field" to identify a green rectangle in the middle of nowhere, like this https://www.openstreetmap.org/#map=17/-23.42452/-47.58841.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.