Added styles for generic shop=* icon

[dkniffin]

Resolves Issue #116

Screenshot:

[jremillard]

Could you do this for office, and craft too? Just a dot with correct color?

[dkniffin]

yea. so office=* would be blue? and craft=* would be...?

[jremillard]

If we are not rendering any craft POI, then just a blue office dot would be 110% OK with me. The more focused the patch probably the more likely it will be accepted. They might want the office change to be a new patch.

[dkniffin]

Yea, I'd submit it as a separate patch anyhow. It looks like we're not rendering any office POI either. Do you have an example of where one is being rendered?

[dkniffin]

Oops. Sorry for the close/reopen

[jremillard]

Oh, if office is not being rendered at all, then like the craft tag, I guess should be a separate discussion... I just know that I often have office tags in my POI mapping....

[gravitystorm]

See also #116 (comment)

Some technical issues with the pull request are

• Unnecessary whitespace changes
• extent_cache and _basemap attributes in project.mml should be kept out of the pull request. I know tilemill can stick them in there automatically, and that's annoying, but use git add -p to avoid including them in the PR

[yohanboniface]

BTW, an option to manage the project.mml file in TileMill collaborative workflow is to use https://github.com/yohanboniface/CartoCC

[dkniffin]

I've made the changes to fix what you said. How do I contribute them, since you closed the pull request?

[matthijsmelissen]

@oddityoverseer13 I'm sorry that nobody answered your question. If you are still around: you can just create a new pull request. Alternatively, you can push it to this branch and ask one of the people with Collaborator-status to reopen the pull request.

[dkniffin]

Oh, I forgot about this. Lemme see if I can find where I put those changes, and I'll push it to this branch.

[dkniffin]

Hmm...Still not sure how to do this. My commit is here: https://github.com/oddityoverseer13/openstreetmap-carto/commit/fac836fcef29f78f1bf3ee526434def1010067a4

I'm not sure how to add that to this pull request though. Does it have to be open first?

[matthijsmelissen]

Strange, it seems indeed that the list of changes does not get updated as long as the pull request is closed. I reopened it now, and the changes show now.

However, the pull request got outdated in the meanwhile: someone else edited the same lines as you did. Would you be able to rebase it on the current version of the code?

[pnorman]

👍 in principle to this.

[dkniffin]

Yes, I will make those changes. Probably tomorrow

[dkniffin]

I made some changes to my local copy. I still need to test them, but they should be good.

[dkniffin]

I think I will create a new pull request for this. I tried to re-fork the repo, but I'm seeing a weird issue that might be a bug with github. I emailed support. I'l update this page when I have any relevant information.

[dkniffin]

I created a new pull request #604. I'm closing this one