Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding antarctic icesheet rendering based on preprocessed shapefiles #1540

Merged

Conversation

@imagico
Copy link
Collaborator

commented May 11, 2015

Since the preprocessed Antarctic icesheet data is now regularly available on openstreetmapdata.com (where also the coastlines come from) this PR adds rendering of the Antarctic ice based on that data. Style-wise this should be an exact equivalent to normal glacier rendering.

See also #960 for more background information.

Rendering examples:

z=6
McMurdo dry valleys
with explicitly mapped glacier

Resolves #960

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2015

@gravitystorm thoughts, as this is a big change, involving new pre-processed data?

@imagico

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 11, 2015

Could we get this out some time soon?

If you have a look at previous discussions you can see this is my third attempt at getting this to render in the style and technically this is about as easy as it gets.

If getting support for this into operations takes some time i understand but it would be good to have a decision.

@gravitystorm

This comment has been minimized.

Copy link
Owner

commented Jul 10, 2015

I'm happy to have these used, and taken from openstreetmapdata.com, but we need to have some source available to generate them in case that site is unavailable.

I realise there's some "magic sauce" with the coastlines wrt comparing them against each other every day, but I'm not concerned about that. We can generate alternative shapefiles from available code if required. Is there existing code available (not necessarily that run by openstreetmapdata.com, but that would be nice) to generate these ice sheets? If so, where does it live?

@tomhughes

This comment has been minimized.

Copy link

commented Jul 10, 2015

@imagico

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 10, 2015

Tom already provided the link - i just pushed the version running on openstreetmapdata.com - the only magic sauce running there in addition is zipping the results and maintaining feature count statistics from osmium_noice (if anyone wants to know - since processing began in March noice feature count decreased from 57278 to 57272 features, explicitly mapped glaciers increased from 634 to 793). And of course we directly use the SQLite db produced by osmcoastline as input and not the shapefiles.

@matthijsmelissen

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2015

@gravitystorm Does that answer your question, or is there anything more we need?

@gravitystorm

This comment has been minimized.

Copy link
Owner

commented Jul 28, 2015

@math1985 I'm happy

@HolgerJeromin

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2015

For all involved people this is probably clear, but on the osmf tile servers there is more adaption needed on their side:
https://github.com/openstreetmap/chef/blob/master/roles/tile.rb#L53-74
A note should be added to a release note of a new osm-carto release.

@matthijsmelissen matthijsmelissen merged commit 89301f1 into gravitystorm:master Jul 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthijsmelissen

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2015

@imagico Thanks a lot!

@pnorman @gravitystorm @matkoniecz Please don't forget to run get-shapefiles.sh when pulling this revision. On deployment, get-shapefiles.sh should also be ran on the rendering server.

@@ -11,6 +11,8 @@ mkdir -p data/simplified-land-polygons-complete-3857
mkdir -p data/ne_110m_admin_0_boundary_lines_land
mkdir -p data/ne_10m_populated_places
mkdir -p data/land-polygons-split-3857
mkdir -p antarctica-icesheet-polygons-3857
mkdir -p antarctica-icesheet-outlines-3857

This comment has been minimized.

Copy link
@matthijsmelissen

matthijsmelissen Jul 28, 2015

Collaborator

@imagico Shouldn't these two lines start with data/? In fact they don't seem to be necessary at all.

This comment has been minimized.

Copy link
@matkoniecz

matkoniecz Jul 29, 2015

Collaborator

see #1699 for PR removing this

@pnorman

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2015

On deployment, get-shapefiles.sh should also be ran on the rendering server

get-shapefiles.sh is not run on the rendering servers at all, nor is it particularly well-suited for production use, with a lack of consideration of failure handling.

@matthijsmelissen

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2015

In any case there should be something on production that downloads the shapefiles...

@tomhughes

This comment has been minimized.

Copy link

commented Jul 28, 2015

Already done in openstreetmap/chef@cecd219 ;-)

@matthijsmelissen

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2015

Thanks @tomhughes!

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2015

Is it intentional that borders are no longer rendered (unlike preview images)?

selection_004

@imagico

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 29, 2015

@math1985 - yes, paths were off but apparently this did not matter. In general get-shapefiles.sh is very testing-unfriendly - you can only test it all together newly downloading all files. This would be good to improve.

@matkoniecz outlines are drawn at ice-water edges and ice-land edges but not at ice-ice edges since those are already drawn by the explicitly mapped glaciers. So if you don't have any glacier data in your database you get missing outlines at the edges, in particular towards the ice shelves.

Thanks everyone to finally get this out, after in total nearly 2.5 years - the land ice polygon in Antarctica was removed on March 16 2013.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2015

@imagico Yes, I checked it without data loaded for this location.

@gregrs-uk

This comment has been minimized.

Copy link

commented Jul 23, 2016

It would be great if the Antarctica shape files could be mentioned under 'Manual download' in INSTALL.md too. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.