Adding amenity=ice_cream and shop=ice_cream icon #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to note that I don't know which property should win over the second one if both are tagged, amenity>shop is just OK in case of ice creams (especially since people are not sure what is the difference), but that was not my choice - it's just automatic in this style that amenity takes precedence. |
|
I like this icon, clear and obvious meaning. I have no preference whatever shop or amenity should have higher priority. |
|
Thanks for preparing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1479 .
Amenity alone:
Shop alone:
Amenity+shop:
