Adding code and icon for shop=sports (runner) #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijsmelissen
added a commit
that referenced
this pull request
Feb 10, 2016
Adding code and icon for shop=sports (runner)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves #1530
Another try with shop=sports:
This time I think we don't have to save the icons for future uses (like sport objects), since currently it seems very unlikely, the runner icon is IMO generic enough (this one is variation on http://osm-icons.org/wiki/File:21009.svg on CC0) plus sports shop is the only "big one" (10k+ uses) left without its own icon and I think they deserve special rendering.