New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaf type rendering with slightly bigger symbols and switch forest patterns to 256 px #2747

Merged
merged 5 commits into from Aug 18, 2017

Conversation

Projects
None yet
3 participants
@sommerluk
Collaborator

sommerluk commented Aug 14, 2017

This is basically the same as #2708. It resolves #822. Closes #2708.

The symbols for known leaf types are slightly bigger (2 px) than in #2708. That’s to make them more attractive (instead of more light) then the unknown-leaf-type-symbol).

The symbols are not simply scaled versions of the previous symbols, but are redesigned and pixel-aligned.

@sommerluk sommerluk referenced this pull request Aug 14, 2017

Closed

leaf_type rendering #2708

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

screenshot 1

Collaborator

sommerluk commented Aug 14, 2017

screenshot 1

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

Same pattern for all leaf types, only the symbols change.

Collaborator

sommerluk commented Aug 14, 2017

Same pattern for all leaf types, only the symbols change.

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

Should easily allow later for both, leaf cycle rendering by filling or half-filling the symbol, and also for leaf cycle rendering by changing the color of the symbol. But that’s not part of this PR…

Collaborator

sommerluk commented Aug 14, 2017

Should easily allow later for both, leaf cycle rendering by filling or half-filling the symbol, and also for leaf cycle rendering by changing the color of the symbol. But that’s not part of this PR…

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Aug 14, 2017

Collaborator

I like this solution. Could you also post some real live rendering?

Collaborator

kocio-pl commented Aug 14, 2017

I like this solution. Could you also post some real live rendering?

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

screenshot 2
screenshot 3
screenshot 4
screenshot 5
screenshot 6
screenshot 7

Collaborator

sommerluk commented Aug 14, 2017

screenshot 2
screenshot 3
screenshot 4
screenshot 5
screenshot 6
screenshot 7

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Aug 14, 2017

Collaborator

These are only unknown/needleleaved, but I'd like also to see mixed, broadleaved and leafless areas. Just one example per type would be enough.

BTW - it would be interesting for me to see preliminary leaf cycle rendering with these symbols.

Collaborator

kocio-pl commented Aug 14, 2017

These are only unknown/needleleaved, but I'd like also to see mixed, broadleaved and leafless areas. Just one example per type would be enough.

BTW - it would be interesting for me to see preliminary leaf cycle rendering with these symbols.

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

screenshot 1
screenshot 2
screenshot 3

Collaborator

sommerluk commented Aug 14, 2017

screenshot 1
screenshot 2
screenshot 3

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

BTW - it would be interesting for me to see preliminary leaf cycle rendering with these symbols.

I would keep leaf cycle rendering out of this PR, also because personally I do not plan to work on that. Anyway, there were basically two proposals for leaf cycle rendering: Either by changing the color of the symbol or by filling it. I think both options are compatible with this PR.

Collaborator

sommerluk commented Aug 14, 2017

BTW - it would be interesting for me to see preliminary leaf cycle rendering with these symbols.

I would keep leaf cycle rendering out of this PR, also because personally I do not plan to work on that. Anyway, there were basically two proposals for leaf cycle rendering: Either by changing the color of the symbol or by filling it. I think both options are compatible with this PR.

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Aug 14, 2017

Collaborator

Could leafless be weaker, to not stand out from the rest? With bigger size it could be probably possible without being hard to recognize.

Collaborator

kocio-pl commented Aug 14, 2017

Could leafless be weaker, to not stand out from the rest? With bigger size it could be probably possible without being hard to recognize.

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

screenshot 1

Collaborator

sommerluk commented Aug 14, 2017

screenshot 1

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 14, 2017

Collaborator

To compare: On the image:

  • right below: broadleaved
  • left below: unknown
  • top: leafless
Collaborator

sommerluk commented Aug 14, 2017

To compare: On the image:

  • right below: broadleaved
  • left below: unknown
  • top: leafless
@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 15, 2017

Collaborator

Switching to 256 px:

screenshot 1

Collaborator

sommerluk commented Aug 15, 2017

Switching to 256 px:

screenshot 1

@sommerluk sommerluk changed the title from leaf type rendering – work on symbols to leaf type rendering with slightly bigger symbols and switch forest patterns to 256 px Aug 15, 2017

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Aug 15, 2017

Collaborator

Both leafless1.svg and leafless2.svg are probably leftovers which should be deleted.

Collaborator

kocio-pl commented Aug 15, 2017

Both leafless1.svg and leafless2.svg are probably leftovers which should be deleted.

@sommerluk

This comment has been minimized.

Show comment
Hide comment
@sommerluk

sommerluk Aug 15, 2017

Collaborator

Both leafless1.svg and leafless2.svg are probably leftovers which should be deleted.

That’s intentional. I wanted to provide all symbols that are not part of the standard jsdotpattern repository so that everybody has available all the necessary files to regenerate them. Also for broadleaved and needleleaved, the original symbol files are provided within this PR.

Collaborator

sommerluk commented Aug 15, 2017

Both leafless1.svg and leafless2.svg are probably leftovers which should be deleted.

That’s intentional. I wanted to provide all symbols that are not part of the standard jsdotpattern repository so that everybody has available all the necessary files to regenerate them. Also for broadleaved and needleleaved, the original symbol files are provided within this PR.

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Aug 15, 2017

Collaborator

Sorry, I missed that they are documented and reside in generating_patterns!

Collaborator

kocio-pl commented Aug 15, 2017

Sorry, I missed that they are documented and reside in generating_patterns!

@kocio-pl kocio-pl merged commit 4bd350f into gravitystorm:master Aug 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sommerluk sommerluk deleted the sommerluk:leavetype02 branch Aug 19, 2017

@nebulon42

This comment has been minimized.

Show comment
Hide comment
@nebulon42

nebulon42 Oct 8, 2017

Contributor

Good job in rendering leaf_type. Much needed. :)

Contributor

nebulon42 commented Oct 8, 2017

Good job in rendering leaf_type. Much needed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment