New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring lightness of farmland color again in line with other landuse #2821

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@matthijsmelissen
Collaborator

matthijsmelissen commented Sep 10, 2017

Now that we have fading of landuse on z8-z12, I think we can revert
the fading of farmland (#1701). The reason for fading farmland was
mainly prominence of farmland on the mid-zoom levels, which is not
a problem anymore after the mid-zoom fading.

This brings the lightness of farmland again in line of the lightness
of similar landuses like grassland.

math1985
Bring lightness of farmland color again in line with other landuse
Now that we have fading of landuse on z8-z12, I think we can revert
the fading of farmland (#1701). The reason for fading farmland was
mainly prominence of farmland on the mid-zoom levels, which is not
a problem anymore after the mid-zoom fading.

This brings the lightness of farmland again in line of the lightness
of similar landuses like grassland.
@matthijsmelissen

This comment has been minimized.

Show comment
Hide comment
@matthijsmelissen

matthijsmelissen Sep 10, 2017

Collaborator

Examples (before/after):

screen shot 2017-09-11 at 00 53 11 screen shot 2017-09-11 at 00 53 25

screen shot 2017-09-11 at 00 54 04 screen shot 2017-09-11 at 00 53 54

Collaborator

matthijsmelissen commented Sep 10, 2017

Examples (before/after):

screen shot 2017-09-11 at 00 53 11 screen shot 2017-09-11 at 00 53 25

screen shot 2017-09-11 at 00 54 04 screen shot 2017-09-11 at 00 53 54

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Sep 11, 2017

Collaborator

What I like about this revert - brown is a more farmland-related color than current "glowing peach" and the rule is clear.
What I don't like about this - this is too dark and plays worse with grass and water, which are quite common on farmlands:

z15
Before
t8bcfn4t
After
uqnge0q

Collaborator

kocio-pl commented Sep 11, 2017

What I like about this revert - brown is a more farmland-related color than current "glowing peach" and the rule is clear.
What I don't like about this - this is too dark and plays worse with grass and water, which are quite common on farmlands:

z15
Before
t8bcfn4t
After
uqnge0q

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Sep 11, 2017

Collaborator

As you can see, it also plays worse with residential areas, which are also quite common, and I've seen that it's not too good with allotments (which are not that common there). I would try to keep the brown, but make it lighter than it was before.

Brown plays better with natural=sand, but I think adding dot pattern to sand (#2746 (comment)) would be still very good idea for sand area (note: this example doesn't include sand pattern):
zedicml2

Collaborator

kocio-pl commented Sep 11, 2017

As you can see, it also plays worse with residential areas, which are also quite common, and I've seen that it's not too good with allotments (which are not that common there). I would try to keep the brown, but make it lighter than it was before.

Brown plays better with natural=sand, but I think adding dot pattern to sand (#2746 (comment)) would be still very good idea for sand area (note: this example doesn't include sand pattern):
zedicml2

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Sep 11, 2017

Collaborator

See also #780 (comment) for proposed natural=heath color change.

Collaborator

kocio-pl commented Sep 11, 2017

See also #780 (comment) for proposed natural=heath color change.

@SomeoneElseOSM

This comment has been minimized.

Show comment
Hide comment
@SomeoneElseOSM

SomeoneElseOSM Sep 11, 2017

Contributor

The brownish colour's definitely better than the current one.

For info I went with #F4EBDF here (which was just making the existing colour "less bright" ) in
https://github.com/SomeoneElseOSM/openstreetmap-carto-AJT/blob/master/landcover.mss#L29 .

Contributor

SomeoneElseOSM commented Sep 11, 2017

The brownish colour's definitely better than the current one.

For info I went with #F4EBDF here (which was just making the existing colour "less bright" ) in
https://github.com/SomeoneElseOSM/openstreetmap-carto-AJT/blob/master/landcover.mss#L29 .

@matthijsmelissen

This comment has been minimized.

Show comment
Hide comment
@matthijsmelissen

matthijsmelissen Sep 17, 2017

Collaborator

Will see what I can do, perhaps some kind of middle option will work out.

For info I went with #F4EBDF here

Is your rendering live somewhere?

Collaborator

matthijsmelissen commented Sep 17, 2017

Will see what I can do, perhaps some kind of middle option will work out.

For info I went with #F4EBDF here

Is your rendering live somewhere?

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl
Collaborator

kocio-pl commented Sep 17, 2017

@matkoniecz

This comment has been minimized.

Show comment
Hide comment
@matkoniecz

matkoniecz Nov 2, 2017

Collaborator

For info I went with #F4EBDF here

It would be necessary to test it, but it looks really well.

Collaborator

matkoniecz commented Nov 2, 2017

For info I went with #F4EBDF here

It would be necessary to test it, but it looks really well.

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Nov 4, 2017

Collaborator

Couple of examples on different levels in Poland:

z8
Before
zr sqop6
After
9zzpi8so

z9
Before
mjthtdir
After
6qbqie8k

z10
Before
nalg znw
After
utxgbge3

z11
Before
msyiuz7v
After
jmb1ke1b

z12
Before
loce57z9
After
si_dfqlo

z13
Before
v_efpemg
After
4dmkcsfr

z16 (with border line)
Before
pfxi2fkn
After
ms9mmrbv

@rrzefox Could you test this change on your server?

Collaborator

kocio-pl commented Nov 4, 2017

Couple of examples on different levels in Poland:

z8
Before
zr sqop6
After
9zzpi8so

z9
Before
mjthtdir
After
6qbqie8k

z10
Before
nalg znw
After
utxgbge3

z11
Before
msyiuz7v
After
jmb1ke1b

z12
Before
loce57z9
After
si_dfqlo

z13
Before
v_efpemg
After
4dmkcsfr

z16 (with border line)
Before
pfxi2fkn
After
ms9mmrbv

@rrzefox Could you test this change on your server?

@matthijsmelissen

This comment has been minimized.

Show comment
Hide comment
@matthijsmelissen

matthijsmelissen Nov 7, 2017

Collaborator

Couple of examples on different levels in Poland:

@kocio-pl Is this based on @SomeoneElseOSM's proposal or the original PR?

Collaborator

matthijsmelissen commented Nov 7, 2017

Couple of examples on different levels in Poland:

@kocio-pl Is this based on @SomeoneElseOSM's proposal or the original PR?

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Nov 7, 2017

Collaborator

It's exactly like in AJT style (area+border). What do you think about it?

Collaborator

kocio-pl commented Nov 7, 2017

It's exactly like in AJT style (area+border). What do you think about it?

@matthijsmelissen

This comment has been minimized.

Show comment
Hide comment
@matthijsmelissen

matthijsmelissen Nov 7, 2017

Collaborator

It looks acceptable to me.

It would be a step away from keeping lightness equal for similar features.

Collaborator

matthijsmelissen commented Nov 7, 2017

It looks acceptable to me.

It would be a step away from keeping lightness equal for similar features.

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Nov 8, 2017

Collaborator

I'm still thinking about making this color a bit darker, but it needs some time to test few different versions, however I like it as a basic shade (less yellow than currently).

Rendering in #2821 (comment) proved me that it should be lighter than some other landuses anyway.

Collaborator

kocio-pl commented Nov 8, 2017

I'm still thinking about making this color a bit darker, but it needs some time to test few different versions, however I like it as a basic shade (less yellow than currently).

Rendering in #2821 (comment) proved me that it should be lighter than some other landuses anyway.

@rrzefox

This comment has been minimized.

Show comment
Hide comment
@rrzefox

rrzefox Nov 11, 2017

@rrzefox Could you test this change on your server?

This (not what's currently in this PR but color f4ebdf) has been deployed and all zoom levels rerendered.

rrzefox commented Nov 11, 2017

@rrzefox Could you test this change on your server?

This (not what's currently in this PR but color f4ebdf) has been deployed and all zoom levels rerendered.

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Nov 15, 2017

Collaborator

I'm still thinking about making this color a bit darker

Testing proved me that AJT style is really too light, so I'd like to find a darker shade.

Collaborator

kocio-pl commented Nov 15, 2017

I'm still thinking about making this color a bit darker

Testing proved me that AJT style is really too light, so I'd like to find a darker shade.

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Feb 5, 2018

Collaborator

Another idea would be to use this color (it's very good on high zoom levels), but just exclude it from fading, because it's light enough and close to the ground color.

Collaborator

kocio-pl commented Feb 5, 2018

Another idea would be to use this color (it's very good on high zoom levels), but just exclude it from fading, because it's light enough and close to the ground color.

@kocio-pl

This comment has been minimized.

Show comment
Hide comment
@kocio-pl

kocio-pl Mar 26, 2018

Collaborator

See also #1991.

Collaborator

kocio-pl commented Mar 26, 2018

See also #1991.

@Tomasz-W

This comment has been minimized.

Show comment
Hide comment
@Tomasz-W

Tomasz-W Jul 15, 2018

@matthijsmelissen Please add "resolves" line for #1991 in first post.

Tomasz-W commented Jul 15, 2018

@matthijsmelissen Please add "resolves" line for #1991 in first post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment