Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tuning of bridge labels #2998

Merged
merged 1 commit into from Dec 29, 2017
Merged

Conversation

sommerluk
Copy link
Collaborator

Fine-tuning of bridge labels

Now the names of bigger bridges are preferred over the names of smaller bridges. The deprecated text-min-distance has replaces by a (slightly bigger) text-margin to avoid confusion with labels that are too near from each other. And margin and halo now scale smoothly with increasing text size.

Before:
screenshot 1

After:
screenshot 2

Before:
screenshot 3

After:
screenshot 4

Before:
screenshot 5

After:
screenshot 6

@kocio-pl
Copy link
Collaborator

My initial idea was to make railway and pedestrian bridges less visible (#2984 (comment)), but just sorting by the size makes sense and it works without any changes in tagging.

In this case it seems that general bridge is just bigger than train bridge, so z15-z16 are now better. However on z14 train bridge label is still rendered instead of general bridge (Most Gdański is a car/tram/pedestrian/bicycle bridge) - is it fixable or do you know the reason?

@sommerluk
Copy link
Collaborator Author

However on z14 train bridge label is still rendered instead of general bridge (Most Gdański is a car/tram/pedestrian/bicycle bridge) - is it fixable or do you know the reason?

Hm, good question. My guess is this is because the river label takes precedence of bridge labels, and at z14 the river label avoids dispaying “Most Gdański”. And than, without “Most Gdański”, there is enough room for the label of the smaller bridge.

@kocio-pl
Copy link
Collaborator

OK, that sounds reasonable and I find this code to be usable tuning.

@sommerluk sommerluk merged commit 730991a into gravitystorm:master Dec 29, 2017
@sommerluk sommerluk deleted the typo01 branch March 18, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants