Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added landcover=grass as grass #3082

Closed
wants to merge 1 commit into from
Closed

Added landcover=grass as grass #3082

wants to merge 1 commit into from

Conversation

pietervdvn
Copy link

For the moment, landcover=grass does not render as grass. As this is subtly different then landuse=grass, this is a valuable addition.

For example, here we would like to map the grass within a residential area. By using 'landcover', we can correctly use this within a residential area.

Rendering won't change visibly here:
screenshot from 2018-02-21 15-59-34

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 21, 2018

I would like to implement it for some time already, but there is a big debate with different views on the topic, so please look at #2548 first and relate to a discussion.

It also desn't look like your code is complete - you need to edit project.mml too to select the objects from database, and this is probably not the proper rendering test, just a screenshot of landuse=grass areas. Please try to install rendering environment, probably this way:

https://github.com/gravitystorm/openstreetmap-carto/blob/master/DOCKER.md

@kocio-pl
Copy link
Collaborator

Since the discussion and coming to some conclusions is the basic problem, I will close this PR now. I hope we will find some common ground at last, so adding the code will make sense.

@kocio-pl kocio-pl closed this Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants