Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finer man_made=pier width #3267

Merged
merged 1 commit into from Jun 21, 2018
Merged

Finer man_made=pier width #3267

merged 1 commit into from Jun 21, 2018

Conversation

meased
Copy link
Contributor

@meased meased commented Jun 17, 2018

Fixes #2652

  • Lowers the stroke width of man_made=pier
  • Adds square line-cap to remove rendering artifacts
  • Does not effect piers mapped as an area

From the discussion in #2652, there was some disagreement on whether piers should represent real world geometries or abstract lines. My opinion is that it doesn't matter which camp you're in, piers are currently much wider in the map than they are in the real world, and as an abstract line, they are still too wide (they are wider than residential roads at zooms 12, 13 and 14).

At this sample area.

Before
before_12
After
after_12

Before
before_13
After
after_13

Before
before_14
After
after_14

Before
before_15
After
after_15

Before
before_16
After
after_16

Before
before_17
After
after_17

Before
before_18
Notice the gaps in the line rendering.
After
after_18

Before
before_19
After
after_19

line-color: @land-color;
[zoom >= 13] { line-width: 3; }
[zoom >= 16] { line-width: 7; }
line-cap: square;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All roads have round as cap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round would look best when two sections join at a non-right angle, but I didn't know how people would feel about round pier ends.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the pier ending. You are right

@imagico
Copy link
Collaborator

imagico commented Jun 17, 2018

For better understanding - this is the line width on the ground (in meters) the proposed change would result in for the different zoom levels.

zoom line-width ground width (Equator) ground width (60°)
12 0.5 19 9.5
13 1 19 9.5
14 1 9.5 4.8
15 2 9.5 4.8
16 2 4.8 2.4
17 4 4.8 2.4
18 4 2.4 1.2

@kocio-pl
Copy link
Collaborator

I like this proposition.

@kocio-pl
Copy link
Collaborator

Regarding width table - I think they are so thin after the change, that it's just a hint that they are here. Which is good, because they are too visible now. And if you want real size and shape, you should map them as area - which is preferred as more accurate.

@kocio-pl kocio-pl merged commit 5bf9221 into gravitystorm:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants