New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aboriginal areas #3521

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@almccon

almccon commented Nov 22, 2018

Fixes #3520

Changes proposed in this pull request:

  • Add rendering for boundary=aboriginal_area and for boundary=protected_area + protect_class=24.

Test rendering with links to the example places:

Before
screen shot 2018-11-22 at 22 nov 9 16 32

After
screen shot 2018-11-22 at 22 nov 10 25 33

More samples:
screen shot 2018-11-22 at 22 nov 11 09 40
screen shot 2018-11-22 at 22 nov 11 08 00
screen shot 2018-11-22 at 22 nov 11 04 23
screen shot 2018-11-22 at 22 nov 10 35 28
screen shot 2018-11-22 at 22 nov 11 36 45

@pnorman

👍 in principle, I haven't done a detailed code review.

@kocio-pl

This comment has been minimized.

Collaborator

kocio-pl commented Nov 24, 2018

As I have written in the issue ticket, it's not easy to find good color - this rendering might be too close to the zoo. So maybe we need some dark orange border; of course the colors can be switched (brown-orange for aboriginal area and orange for zoo) if that would work better. That needs testing. Also wiki documentation is needed, following discussion on the Tagging list to make sure if we really need 2 different schemes (maybe we do).

Another, smaller issue would be to rename data layer into something like protected-areas-boundaries instead of creating another similar layer called aboriginal-lands-boundaries.

@jeisenbe

This comment has been minimized.

Contributor

jeisenbe commented Nov 28, 2018

@almccon, if the orange doesn't work, another option would be to switch tourism boundaries (eg zoos, theme parks) to a shade of violet or purple, because we are planning to change administrative boundaries to gray, thus making purple available for tourism features.

@sommerluk

This comment has been minimized.

Collaborator

sommerluk commented Nov 28, 2018

If violet becomes available, it should not be a minor feature like this one to occupy it again (blocking a hole coulor).

@jeisenbe

This comment has been minimized.

Contributor

jeisenbe commented Nov 28, 2018

@Adamant36

This comment has been minimized.

Contributor

Adamant36 commented Nov 28, 2018

Isn't violet/purple being used for shops currently? I think it works good there. The new gastronomy icon is sort of orangish already also. Maybe the dark blue color that's currently being used for railway stations would work. Since its the only thing that I know of with the color.

There was a discussion somewhere around here about changing that and a few other colors around that never went anywhere. Maybe it would be worth revisiting and putting this stuff/that stuff under one umbrella. Since they are all sort of related. As far as zoos, amusement parks etc goes. I think it would be the wrong color for this issue though.

Orange might actually work here despite its food association because I doubt people think aboriginal areas are related to restaurants. Plus, its kind of an earth tone. Which sorta fits.

@matkoniecz

Thank you very much for a PR! Especially such well formatted one (with example images etc).

Unfortunately currently proposed rendering is far too close to rendering of zoos/theme parks. I understand that with style rendering so many features it is hard to find style that works is not already used for something else but in this case implication of rendering this feature in style very close to zoos are quite problematic.

Can you experiment with some other stylings?

@matkoniecz

This comment has been minimized.

Collaborator

matkoniecz commented Dec 7, 2018

@almccon Would it be OK to mark this PR as assigned to you for now?

@almccon

This comment has been minimized.

almccon commented Dec 7, 2018

@matkoniecz Yes, please go ahead and assign it to me, thanks. I will try some alternative color treatments to avoid the zoo conflict. I just haven't had time to do it yet.

@kocio-pl

This comment has been minimized.

Collaborator

kocio-pl commented Dec 14, 2018

We have now boundary=aboriginal_lands documented:

https://wiki.openstreetmap.org/wiki/Tag:boundary%3Daboriginal_lands

and i agree that we should now render both schemes.

So, we just wait for solving rendering problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment