New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change allotments color and pattern #3548

Merged
merged 7 commits into from Dec 19, 2018

Conversation

Projects
None yet
5 participants
@jeisenbe
Copy link
Contributor

jeisenbe commented Dec 3, 2018

Fixes #3411

Changes proposed in this pull request:

  • Change allotments color to garden/grass green, i.e. #cdebb0, Lch(90,32,128)
  • Change pattern to near-white, light green 2x2 pixel squares on a 4x4 pixel grid
    *Pattern is #f2faeb (Lch97,8,130) approximately 75% white with 25% grass color
  • Consolidate allotments on the same lines as garden and grass for text label rendering.
  • Add allotments.svg and allotments.md to describe generating this pattern

Explanation:
Allotment gardens are currently a terra-cotta colour, similar to farmyards, with a pattern of white dots every 8 pixels. This looks nice and the relation to farmyards is sensible, but it does not immediately suggest that allotments are a type of garden.

This PR will change allotments to use the same shade of green as landuse=garden (and landuse=grass), while changing the pattern to be distinct from gardens and grass areas.

Test rendering with link:
http://openstreetmap.org/#map=16/52.1940/21.0404
Warsaw z15 master
warsaw-z15-master
z16
warsaw-z16-master

After z15
warsaw-z15-new
z16 after
warsaw-allotments-after-z16

Also see previous test renderings in issue #3411, eg:
#3411 (comment)
#3411 (comment)
#3411 (comment)

Change allotments color and pattern
Change allotments color to garden/grass green, change pattern to 2x2 pixel squares on a 4x4 pixel grid, with near-white light green color (approximately 75% lighter green than grass color for pattern).
Consolidate allotments on the same lines as garden and grass for text label rendering.

@jeisenbe jeisenbe force-pushed the jeisenbe:allotments branch from 61b3cf7 to 32cfc11 Dec 3, 2018

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 3, 2018

Allotments with gardens and grass

Glauchau, Germany: allotments next to grass
glauchau-2px-4grid-on-garden

Northern Ireland: allotments by residential gardens
export-21

Allotments between an area of grass and an area of garden
export-7

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 3, 2018

Flamengos, Azores Islands
http://www.openstreetmap.org/#map=15/38.55036/-28.65888

z15 - Small patches of allotments with many other green features (orchards, gardens, grass etc)
z15-flamengos-2px-white75-on-4p-grid-garden

z16 - Small areas of Allotments, garden, orchard, plant nursery, grass,
z16-flamengos-2px-white75-on-4p-grid-garden

z17 - Allotments next to farmland, near botanic garden and orchards
z17-sao-lourenco-2px-white75-on-4p-grid-garden

Wales, Great Britain
Trethomas, Wales:
Allotments next to grass/meadow (in center)

Marshfield, Wales. Allotments on mid-right, garden on left by church

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 9, 2018

Could you provide the code of this pattern but with #ddeec3 as a foreground? All is good with high zoom levels, but on midzoom (when the area is small) it's close to the grass. I'd like to check it, but pattern generation and producing raster image is not that simple.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 9, 2018

It looks like on z13 pattern is not used, which is OK for orange, but with the color change it looks exactly like grass (4x zoom to show it):

https://www.openstreetmap.org/way/25345944#map=13/52.1935/21.0956

pxayfnie

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 9, 2018

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 9, 2018

You're right, gardens are already grass-looking on z13. Could you produce the lighter green pattern to test it anyway?

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 10, 2018

I've pushed a commit with the requested code for testing.

  1. Allotments - #ddeec3 is used as the background for allotments with a pattern in #f6fbef (approximately 75% white plus 25% #ddeec3, by HSL).

(This commit is not ready to merge; the svg is not included and the file name would need changing, but it will work for testing)

My concern about this option is that it would be introducing yet another shade of green, in between Grass and Farmland, for a pretty specific tag. Also, at high resolution (eg on a retina display), this color can appear to blend with the pattern, with the result looking rather similar to farmland. That's why I've been recommending using the garden / lawn color for the allotments background.

Warsaw, z16
z16-allotments-f6fbef-2px-by-4px-on-ddeec3

z15
z15-allotments-f6fbef-2px-by-4px-on-ddeec3

z14
z14-allotments-f6fbef-2px-by-4px-on-ddeec3

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 10, 2018

Thanks. It is too light to see the pattern, so maybe 75% grass + 25% farmland would be better. I would like to have something that looks different than grass even when the area is too small to see the pattern anyway, but the pattern is important when zooming in.

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 11, 2018

Here are a few more options. I checked for what could count as 75% grass plus farmland; the option with the most contrast from grass is #d8ecba, Lch(91,27,124)

25-50-75-grass-to-farmland

  1. Allotments in #d8ecba with 75 percent white for pattern
    z15a
    3-d8ecba-75percent-llandaff
    z13
    3-marshfield-z13
    z14
    3-marshfield-z14
    z15b
    3-marshfield-z15
    z15c
    3-st-mellons-z15

I feel that the tests above were not much of an improvement; the color is still too close to grass. I also tried the current campsite / caravan site color, but this is not much of an improvement (it's also similar to grass).

Here is one more option. I've shifted the color to be more blue, similar to orchards, vineyards and plant nurseries, but lighter and less saturated. This makes the allotments more similar to parks, leisure and orchard, though it is still close to the grass/garden color. #d7f3c9 is Lch(93,24,134)

  1. Allotments in #d7f3c9 with 75 percent white for pattern
    z15a
    4-d7f3c9-75percent-llandaff-z15
    z15b
    4-bronynant-z15
    z13
    4-marshfield-z13
    z14
    4-marshfield-z14
    z15c
    4-z15-marshfield
    z15d
    4-st-mellons-z15

(I also tried both of these background colors with 100% white squares for the pattern, but this is too much contrast, so I haven't bothered to upload these).

@Adamant36

This comment has been minimized.

Copy link
Contributor

Adamant36 commented Dec 11, 2018

Hhhmm, I don't know about the squares. It makes the area look out of place since nothing else uses them and they are to uniform. Maybe a pattern would be better. Either with or without them though, what about a slightly darker tint to farmland. I'm sick of green colors. So I liked that allotments weren't green. It doesn't seem like the right color for it. I don't think of gardens as green. Let alone allotments. Its more of a civic amenity (like university grounds) or a social facility then a surface.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 11, 2018

They are similar to both garden and farmland, so they should be green also. Park has social meaning too, but green is for vegetation.

I will look at the examples closer later.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 16, 2018

Thanks - I tested it and it's too light, I don't see the pattern. So let's go back to the original idea (just keep "converted to PNG" in documentation).

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 16, 2018

I have one more idea - what about using green shade of former scrub? It's quite dark (so the pattern would be visible) and distinguishable from other greens.

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 16, 2018

The previous scrub color (#b5e3b5) is identical to the current golf course color, so I believe we would need to change golf courses to use this.

It was test number 5 back in the issue discussion, see #3411 (comment)

The golf color is also fairly similar to the current orchard/vineyard/plant_nursery background color, #aedfa3.

Golf left (Lch 86,29,143), orchard/plant_nursery right (Lch 84,36,138)
golf-vs-orchard

I previously tested the orchard/plant nursery color, #aedfa3. It could work, and I suppose allotments are similar to plant nurseries (although I would think thye are closer to grass/garden normally). I tested this with the larger square pattern before, but I'll need to try it with the smaller squares. Here's a couple of examples with the larger pattern:

costco-z16-mix-on-orchard

trethomas-z14-mix-on-orchard

fairwater-z16-mix-on-orchard

I can push commits with both of this options, for testing, if interested.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 16, 2018

Yes, please test this color, but with current pattern.

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 16, 2018

Test 18: Allotments in golf-color #b5e3b5 with 75% opacity white pattern:
Lch(86,29,143)
z15
z15-golf-color

z16
z16-golf-color

Test 19: Allotments in plant_nursery/orchard/vineyard color #aedfa3.
Lch(84,36,138)

z15
z15-orchard-color

z16
z16-orchard-color

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 16, 2018

It looks too dark, especially on z13, when we have no pattern, so I believe original change proposition is the best at this moment.

Change allotments color and pattern
    Change allotments color to garden/grass green, change pattern to 2x2 pixel squares on a 4x4 pixel grid, with near-white light green color (approximately 75% lighter green than grass color for pattern).
    Consolidate allotments on the same lines as garden and grass for text label rendering.
@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 16, 2018

OK, so we are going with #cdebb0, same as gardens and grass. I've pushed the changes. This should be identical to the initial commit, as seen here: #3548 (comment)

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 17, 2018

Hm, do we have to drop the pattern at z13? Could you try how would it be without dropping it at all?

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 17, 2018

@kocio-pl, the other green landuse patterns generally begin at z14, eg vineyards, orchards, plant_nursery, garden, cemetery. These areas are generally fairly small and the pattern is unlikely to be visible at low zoom levels for most allotments (though your huge ones in Warsaw may be an exception)

Some of the natural patterns begin much earlier, because they can cover large areas. Specific wetland patterns begin at z14, along with beach and scrub. Screen/shingle and forests begin at z13, quarries and reef at z10. Bare_rock, sand, (generic) wetland and glacier patterns begin at z5.

The other issue is that z12 is where the landcover colors start to be faded, so it becomes harder to distinguish subtle differences.

I've tested this on the two larger towns/cities in southern Wales. Cardiff has several fairly larges areas of allotments; Newport only has small allotments (as is common in Britain).

Cardiff z14, with pattern:
z14-cardiff-allotments

z13, No pattern:
z13-cardiff-no-pattern

With pattern:
z13-cardiff-allotments

z12, No pattern:
z12-cardiff-no-pattern

With pattern:
z12-cardiff-allotments

Newport z14
z14-newport-allotments

z13 No pattern:
z13-newport-no-pattern

With pattern:
z13-newport-allotments

z12 No pattern:
z12-newport-no-pattern

With pattern:
z12-newport-allotments

It looks like the pattern could work on z13, though it's only clearly visible on the larger allotments and can be confusing on small allotments that show only a few pixels. But z12 won't work.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 17, 2018

Since I see nothing bad with rendering pattern on small allotments and there are more places with the big ones, like here:

https://www.openstreetmap.org/#map=13/50.3657/30.6137
https://www.openstreetmap.org/#map=13/52.4557/13.4252
https://www.openstreetmap.org/#map=13/54.1680/19.4217

let's render allotments pattern from z13+. I see no problems with other patterns on low zoom levels so far, so it might be tweaked in the future in general (also in gardens etc.), but it's not worth digging even deeper for now.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 19, 2018

@jeisenbe It would be nice to have this merged in the new release on Friday, do you think you can add z13 rendering soon?

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 19, 2018

@kocio-pl kocio-pl merged commit 5208585 into gravitystorm:master Dec 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 19, 2018

Thanks, that was quite hard work to test, now let's see how it works full time on the map...

@dktue

This comment has been minimized.

Copy link

dktue commented Dec 22, 2018

I love it on the map! :-)

@polarbearing

This comment has been minimized.

Copy link
Contributor

polarbearing commented Dec 25, 2018

Thanks for all the fine-tuning, and good to see the little-squares idea works so well. Here is a nice before-after effect on adjacent tiles ;-)
allotments-before-after

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 26, 2018

I think some boundary line is missing in many cases.

@polarbearing

This comment has been minimized.

Copy link
Contributor

polarbearing commented Dec 26, 2018

Indeed, which surprised me a bit since the top post shows boundaries both for before and after.
However in the code I see no line drawn, neither before nor after. Maybe they are barriers?

Should we focus on this one alone, or open a more general issue 'review boundaries for filled area'? At least school needs it darkened, there is one open.

@kocio-pl

This comment has been minimized.

Copy link
Collaborator

kocio-pl commented Dec 26, 2018

Please make as simple PRs as possible, because I feel overwhelmed currently. It does not hurt to make more merges, while reviewing complex proposals with many days of discussions and interdependencies is very hard for me and still we have no other active reviewers with merging rights.

This is general remark, not only related to this proposition. Sorry for this inconvenience.

@jeisenbe

This comment has been minimized.

Copy link
Contributor

jeisenbe commented Dec 27, 2018

@Adamant36

This comment has been minimized.

Copy link
Contributor

Adamant36 commented Dec 27, 2018

Its questionable to me if things like orchards or vineyards, which dont usually represent the actual landuse boundary and only the bounds of the crop being grown are easy to seperate from other things on their own, need outlines in the first place (maybe not with plant nurserys though). So I suggest it goes through rigorous disscussion in their own seperate issues if they are going to be considered.

Adamant36 added a commit to Adamant36/openstreetmap-carto that referenced this pull request Dec 28, 2018

@jeisenbe jeisenbe deleted the jeisenbe:allotments branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment