Add highway=pedestrian area label #375

Closed
wants to merge 3 commits into
from

Projects

None yet

5 participants

@mrwojo
mrwojo commented Mar 2, 2014

See #355. The styling is copied from highway=pedestrian line label, adjusted for polygons. Note that there are practically no highway=pedestrian nodes (77 instances). JOSM's stylesheet/validator rejects those.

(Also cleans up a confusing comment that I wrote previously.)

@hlaw
hlaw commented Mar 7, 2014

Should we also be restoring highway=service + area=yes labels? Both highway=service and pedestrian can be areas as described in the wiki page for highway. Both should be common - from Taginfo, there are 69782 highway=pedestrian areas and 32650 highway=service areas (although labelling for highway=service should be rarer).

@pnorman
Collaborator
pnorman commented Mar 7, 2014

32650 highway=service areas (although labelling for highway=service should be rarer).

I'll check how many objects there are with name, highway=service and area=yes.

@matkoniecz
Collaborator

I think that it is not important how many are tagged with name, just show it - why not? It is not some kind of ugly special case.

@pnorman
Collaborator
pnorman commented Mar 8, 2014

32650 highway=service areas (although labelling for highway=service should be rarer).
I'll check how many objects there are with name, highway=service and area=yes.

1327

@gravitystorm
Owner

Thanks for the PR, and it's certainly something that needs adding. However, I'd prefer if you can doing the following:

  • move the unrelated comment fixups into a separate commit/PR.
  • put the pedestrian labelling CSS into the roads.mss in proximity (e.g. below) the related rules for line labelling. That way if anyone is looking at one set of highway-pedestrian-text rules the other set is close by in the same mss file.
  • You should create a new layer (e.g. '#roads-area-text-name'), rendering immediately before #roads-text-name, so that it's easy for people to turn off all roads labelling (or conversely, all miscellaneous text) without having some highway=pedestrian labels caught up in a different set of labels.

(The choice of 'before' is unusual since they might block more important road labels, but is based on the idea that area labels only get one chance to be placed, whereas linear labels can slide around a bit more).

mrwojo added some commits Mar 11, 2014
@mrwojo mrwojo Revert "Add highway=pedestrian area label"
This reverts commit 61e9104.
6b040e5
@mrwojo mrwojo Add #roads-area-text-name
Labels for highway=pedestrian areas. Could expand to more highway types.
3f54d1f
@mrwojo
mrwojo commented Mar 11, 2014

Done and tested.

@gravitystorm
Owner

Merged as 225b674

@mrwojo mrwojo deleted the unknown repository branch Mar 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment