Fix living_street on z12 #385

Merged
merged 6 commits into from Mar 14, 2014

Projects

None yet

2 participants

@math1985
Collaborator
math1985 commented Mar 6, 2014

Render highway=living_street on z12 like residential roads instead of
wider.

This PR depends on #382.

math1985 added some commits Mar 3, 2014
@math1985 math1985 Restore rendering of service roads and living_streets in tunnels and …
…on bridges
3c74350
@math1985 math1985 Resolve bug that causes spur, siding and yard not to render properly 541aa94
@math1985 math1985 Do not hide some bridges in z12/z13
- Do not hide secondary road bridges on z12
- Do not hide tertiary, residential, unclassified, and road bridges on z13

Conflicts:

	roads.mss
c60c077
@math1985 math1985 Collapse definitions for normal roads, tunnels and bridges
This collapses, per road type, definitions that are the same for normal
roads, tunnels and/or bridges.
In addition, it gives some instances clearer names.
This makes it more easy to maintain the code, and to detect inconsistent
definitions.

Changes in rendering:
* Render minor service roads on bridges and tunnels smaller and on higher
  zoomlevels only, just like minor service roads that are not on a
  bridge or tunnel. This solves #269 on Github and 3883 on trac.
* Restore bridges of bridleway, footway, cycleway, path, lightrail on
  z13.
0619b0b
@math1985 math1985 Fix living_street on z12
Render highway=living_street on z12 like residential roads instead of
wider
9c60198
@gravitystorm
Owner

This applies the 1px-grey rule to living streets on z13, not to z12 which is what I think you meant.

See also the first rule in the CartoCSS style guide section of the README :-)

@math1985
Collaborator

Thanks for catching, I will correct both issues. I close this PR for now.

@math1985 math1985 closed this Mar 11, 2014
@math1985 math1985 Correct zoomlevel living_street
Apply 1px-grey rule on living_street to z12 instead of z13
88311b3
@math1985 math1985 reopened this Mar 14, 2014
@math1985
Collaborator

Both issues have been addressed. I therefore reopened this pull request.

@gravitystorm gravitystorm merged commit 88311b3 into gravitystorm:master Mar 14, 2014
@math1985 math1985 deleted the math1985:living_street-z12 branch Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment