various updates: 1) fountains 2) nightclubs 3) religion icons #47

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
7 participants
Contributor

Rovastar commented Apr 22, 2013

Adding updates for fountains, nightclubs, religious symbols.

Had to revert the parking area for sports clubs as other parking areas may have clashed.

  1. Adding fountain icon and rendering

Added the fountain icon to the map

https://trac.openstreetmap.org/ticket/4573
and
https://trac.openstreetmap.org/ticket/2381

image from slightly modified pic from wiki (I can make smaller if needed (so pngs sizes in general are all over the place I might standardise this later)

http://wiki.openstreetmap.org/wiki/Tag:amenity%3Dfountain

amenity = fountain tag count: 35519

  1. Added nightclub icon and rendering

https://trac.openstreetmap.org/ticket/2697

used one of the attached svg files this in the ticket - scaled to fit.

amenity=nightclub tag count: 7166

  1. Added religion symbols

We were missing some key religions.
added:
hindu (tag count: 3470)
buddhist (tag count: 9641)
shinto ((tag count: 1893)
taoist (tag count: 553)

Created .png by me based on wikipedia pd image. And tweaked the amenity points page so it is displayed.
Now anything over 150 for religion tags is covered
http://taginfo.openstreetmap.org/keys/?key=religion#values

Hindu ticket: https://trac.openstreetmap.org/ticket/4168

Rovastar added some commits Apr 21, 2013

@Rovastar Rovastar Update project.mml
For fixing Parking not appearing on Sport Centres
https://trac.openstreetmap.org/ticket/4419

This is because we render landuse (which includes parking areas) before Sport Centres.

Split the layer for landuse and removed parking.

Added parking-area separately and placed just after sport centre rendering.

Use landcover.mss which I am updating now.
62d471c
@Rovastar Rovastar For fixing Parking not appearing on Sport Centres with related projec…
…t.mss

For fixing Parking not appearing on Sport Centres
https://trac.openstreetmap.org/ticket/4419

This is because we render landuse (which includes parking areas) before Sport Centres.

Split the layer for landuse and removed parking.

Added parking-area separately and placed just after sport centre rendering.

Landcover changes

Removed parking from and added it as a separate module/#parking-area
0dd1c1f
@Rovastar Rovastar Updating changes for Parking on sports centres, fountain, club
Initial update to get it all in synch, parking on sports centres and
fountains, and nightclubs
2fdaaac
@Rovastar Rovastar fixing fountains and nightclubs removing car parking for sports
fixing fountains and nightclubs removing car parking for sports centres
which didn't work 100%
7e92df1
@Rovastar Rovastar Added Hindu religion icon and rendering
Added Hindu religion icon and rendering

https://trac.openstreetmap.org/ticket/4168
8c8dd8c
@Rovastar Rovastar Added religious icons
Buddhist, Shinto and taoist
e5320db

+1 on the icons. I was about to do a pull request too for the hindu icon as there are a lot of them in some countries and as it stands they have a rendering issue showing them as a brown square.
Thanks for creating the pull request.

Collaborator

pnorman commented Aug 6, 2013

@gravitystorm I'm not so sure on the other changes, but what do you think about me pulling out the new religious icon changes into a new branch for merging? The fountains and nightclubs are new features which require more consideration, but the religious icons are changing the existing icons to more suited ones.

For reference, existing icon:
97611

Contributor

Rovastar commented Aug 9, 2013

I had lost interest/ignored/forgotten all about this as I didn't think anything would happen with this 4 months down the line and no update/interest. I was under the impression that Andy didn't want any new icons (at the end of his the sotm us talk basically just slagged off people (or maybe just me as I was the only one that made a pull request with icons shrug) creating icons as they are not wanted/needed)

I don't understand the problem with adding more stuff like fountains, etc if there are enough of them in the database hence they are features that people want to map/want to appear on the map.

What considerations are you think of pnorman? If they are useful or not?, etc

Collaborator

pnorman commented Aug 10, 2013

The style is already overloaded with rendered stuff, you can't fit the rich information the OSM database contains into one rendering.

Another cartographic is that you don't want too many things for people to know what everything means - the most obvious measure of this would be the size of the map key.

This particular pull request also suffers from the more technical problem that it's mixing unrelated change, not all of which may be desirable (and needs updating to be merged anyways)

Contributor

Rovastar commented Aug 10, 2013

Just to address your points there.

a) The style being overloaded is not a fact but a matter of taste. I and many other think there can be more information rendered. One of the biggest complains and is a tangible measure of users I have spoke to dropping out of the project is that things they map are not rendered. I get questions when I reach out to them like "Why should I map just if stuff doesn't appear on the map (get render on the main style). Experienced users of OSM like ourselves know it is a database but for many newcomers it is (also) a map.
Personally I think the main style (or at least a layer style) should show as much as we can sensibly).

b) I see no problem with a map key for more or actually relevant information.
It is 2013 and are looking at a database and on the net. We need to stop thinking like printed maps for the legend/key.
What we should do is create a dynamic key based on what is on the screen.
If I am looking at urban inner city, say the richly mapped central London I don't want to know:

Cable Cable car and chair lift
Runway Airport Runway and taxiway
Apron Airport apron and terminal

(Which are currently high up of list)
As they do not appear on the map.

We should/could create a dynamic list based on the screen display. The bounding box of the area display and dynamic create a list of the contained features. So it would not show motorways, airports, etc if they are not there.
Probably only practical if we are greater then zoom level 15 or something.

I don't a massive resource issue as view few people will view the key.

This would get not only a smaller key/legend but also a relevant one to the user.

c) I understand that this needs to be updated. Yeah they could/should be in separate changes I asked Andy no preference was forthcoming about how do do this. Really the way stupid GitHub wants to work is to take all my changes merge them in one go. It is difficult to synch relevant changes I have in my version into the master style.
Maybe I don't understand GitHub enough but I though I could only have 1 pull request at one time. shrug
But if there was interest I would have split these up.

My 2 cents on this is that the main style is currently very, very dense. The osm.org needs to have different style sheets for different verticals. Default one (this one), hiking/biking, public transport, natural/land cover/water, sports, rail, etc. That way, everybody does not need to pile into this style sheet.

Contributor

CloCkWeRX commented Oct 15, 2013

Split off religious icons to be a seperate PR

Collaborator

pnorman commented Oct 15, 2013

At this point the PR is stale and needs to be split anyways, so I'm going to go ahead and close it to avoid duplication between this and the new ones that are being opened.

pnorman closed this Oct 15, 2013

Collaborator

matkoniecz commented Oct 23, 2013

@Rovastar

You may use branches in git to create multiple separate pull request (and anyway, the best way to work is to have separate branches for separate features).

Contributor

CloCkWeRX commented Nov 14, 2013

The fountains and nightclubs are new features which require more consideration, but the religious icons are changing the existing icons to more suited ones.

There are original trac tickets for these, indicating at least some interest from the community. Since I've sorted out #229 ; I can either leave this or tease those changes out individual for consideration.

+1/-1, folks?

Owner

gravitystorm commented Nov 14, 2013

Please don't encourage voting - discussion is welcome, but let's discuss merits not popularity.

In general, I don't have a strong desire for more icons in the style at this time. There are many other things to improve, and I have great concerns about legibility and complexity already.

Contributor

CloCkWeRX commented Nov 14, 2013

My intent was purely +1/-1 to the action of making a new pr, to discuss the
merits; not to the changes themselves. That said, Getting a wontfix vibe
from pnorman and yourself right now, but didn't want to abandon it on just
1x persons opinion.
On 14/11/2013 6:43 PM, "Andy Allan" notifications@github.com wrote:

Please don't encourage voting - discussion is welcome, but let's discuss
merits not popularity.

In general, I don't have a strong desire for more icons in the style at
this time. There are many other things to improve, and I have great
concerns about legibility and complexity already.


Reply to this email directly or view it on GitHubhttps://github.com/gravitystorm/openstreetmap-carto/pull/47#issuecomment-28466214
.

Collaborator

matkoniecz commented Nov 14, 2013

I consider fountains important to be displayed at least at highest zoom level, it is not only me - many traditional maps also include this kind of information.

But this is mostly matter of opinion.

Contributor

Rovastar commented Nov 14, 2013

There is more work needed in general to improve the style. And I am focusing my efforts on this at the moment

However I do think some streams of work can be done together and don't clash and things like this are one of them.

I am not going to try an push through the changes for this pull request through at this time though.

The features in the pull request were for popular (many thousands of tags), useful and meaningful items to be included. Religious icons especially increase the diversity prospects for the OSM in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment