Start using variables for colors #58

Merged
merged 3 commits into from Sep 4, 2013

Conversation

Projects
None yet
3 participants
Contributor

ian29 commented Jun 10, 2013

I've only started on this for the colors present in landcovers.mss, but it will unlock tasks like #56 and #57 (or at least make them much much easier to implement)

I also recognize that this is somewhat against the spirit of this bit from the README:

Care will be taken to not get too clever with variables and expressions. While these often make it easier to customise, experience has shown that over-cleverness (e.g. interpolated entities) can discourage contributions.

While I don't want to discourage contributions, I think making the style more structured + logical is important. Keeping consistent colors across thematic features will be important for making the map design flatter and more legible as we progress on Version 3 improvements.

All that being said, I'd love to hear reasons why this is might hurt contributions.

gravitystorm merged commit adbfc10 into gravitystorm:master Sep 4, 2013

Owner

gravitystorm commented Sep 4, 2013

Apologies for taking so long to review, update and merge this! Thanks for the work.

Contributor

ian29 commented Sep 4, 2013

:D

Contributor

CloCkWeRX commented on landcover.mss in adbfc10 Sep 23, 2013

The previous color was #9d9d6c, or what you refactored to the construction variable; now it's pink.

Contributor

ian29 replied Sep 23, 2013

my bad, feel free to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment