Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add rendering for landuse=greenhouse_horticulture #82

Closed
wants to merge 1 commit into from

4 participants

@mfornasa

Fixes #78

@math1985 math1985 added the landcover label
@math1985
Collaborator

This tag gas 18 613 occurrences. As far as I'm concerned, it can be merged.

@math1985 math1985 changed the title from Rendering of landuse=greenhouse_horticulture to Add rendering for landuse=greenhouse_horticulture
@matkoniecz
Collaborator

I strongly dislike the tag itself, I think that such areas should be tagged as landuse=farmland, farmland=greenhouse_horticulture.

But at least such areas should be rendered exactly like farmland - yet another landuse colour is not a good idea.

@dieterdreist
@mfornasa

I also think that this can be really useful for orientation purposes. Greenhouses are, in fact, buildings, as opposed to farmland, which is usually without buildings.

@matkoniecz
Collaborator

Greenhouses are, in fact, buildings

Yes, so greenhouses will be tagged and rendered as buildings. Is it reall necessary to make a separate colour for landuse?

@matkoniecz
Collaborator

@dieterdreist

-1, they are so different that they merit their own rendering style IMHO

I am not convinced. For example patches of small fields, rice terraces, giant corn fields, cauliflower fields, fields of sunflowers, intensively irrigated fields on desert and cotton fields are also really different. Is it a good idea to have a separate rendering for all kinds of farmland?

@dieterdreist
@matkoniecz
Collaborator

vineyards

also - orchards.

@math1985 math1985 referenced this pull request from a commit in math1985/openstreetmap-carto
@math1985 math1985 Render greenhouse_horticulture as farmland
Supercedes/resolves #82.
Fixes #78.
ebc5053
@math1985
Collaborator

Superseded by #1435.

@math1985 math1985 closed this
@math1985 math1985 referenced this pull request from a commit in math1985/openstreetmap-carto
@math1985 math1985 Render greenhouse_horticulture as farmland
Supercedes/resolves #82.
Fixes #78.
e90be21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 16, 2013
  1. @mfornasa
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +4 −0 landcover.mss
  2. +1 −1  project.mml
View
4 landcover.mss
@@ -44,6 +44,10 @@
[feature = 'landuse_orchard'][zoom >= 10] {
polygon-pattern-file: url('symbols/orchard.png');
}
+
+ [feature = 'landuse_greenhouse_horticulture'][zoom >= 10] {
+ polygon-fill: #dceaee;
+ }
[feature = 'landuse_cemetery'],
[feature = 'landuse_grave_yard'],
View
2  project.mml
@@ -139,7 +139,7 @@
],
"Datasource": {
"type": "postgis",
- "table": "(select way, religion,\ncoalesce (aeroway, amenity, landuse, leisure, military, \"natural\", power, tourism, highway) as feature from (\nselect way,\n('aeroway_' || (case when aeroway in ('apron', 'aerodrome') then aeroway else null end)) as aeroway,\n('amenity_' || (case when amenity in ('parking', 'university', 'college', 'school', 'hospital', 'kindergarten', 'grave_yard') then amenity else null end)) as amenity,\n('landuse_' || (case when landuse in ('quarry', 'vineyard', 'orchard', 'cemetery', 'grave_yard', 'residential', 'garages', 'field', 'meadow', 'grass', 'allotments', 'forest', 'farmyard', 'farm', 'farmyard', 'recreation_ground', 'conservation', 'village_green', 'retail', 'industrial', 'railway', 'commercial', 'brownfield', 'landfill', 'greenfield', 'construction', 'wood') then landuse else null end)) as landuse,\n('leisure_' || (case when leisure in ('swimming_pool', 'playground', 'park', 'recreation_ground', 'common', 'garden', 'golf_course') then leisure else null end)) as leisure,\n('military_' || (case when military in ('barracks', 'danger_area') then military else null end)) as military,\n('natural_' || (case when \"natural\" in ('field','beach','desert','heath','mud','grassland','wood','sand','scrub') then \"natural\" else null end)) as \"natural\",\n('power_' || (case when power in ('station','sub_station','generator') then power else null end)) as power,\n('tourism_' || (case when tourism in ('attraction', 'camp_site', 'caravan_site', 'picnic_site', 'zoo') then tourism else null end)) as tourism,\n('highway_' || (case when highway in ('services', 'rest_area') then highway else null end)) as highway,\ncase when religion in ('christian','jewish') then religion else 'INT-generic'::text end as religion\n from planet_osm_polygon\n where landuse is not null\n or leisure is not null\n or aeroway in ('apron','aerodrome')\n or amenity in ('parking','university','college','school','hospital','kindergarten','grave_yard')\n or military in ('barracks','danger_area')\n or \"natural\" in ('field','beach','desert','heath','mud','grassland','wood','sand','scrub')\n or power in ('station','sub_station','generator')\n or tourism in ('attraction','camp_site','caravan_site','picnic_site','zoo')\n or highway in ('services','rest_area')\n order by z_order,way_area desc\n ) as landcover\n) as features",
+ "table": "(select way, religion,\ncoalesce (aeroway, amenity, landuse, leisure, military, \"natural\", power, tourism, highway) as feature from (\nselect way,\n('aeroway_' || (case when aeroway in ('apron', 'aerodrome') then aeroway else null end)) as aeroway,\n('amenity_' || (case when amenity in ('parking', 'university', 'college', 'school', 'hospital', 'kindergarten', 'grave_yard') then amenity else null end)) as amenity,\n('landuse_' || (case when landuse in ('quarry', 'vineyard', 'orchard', 'greenhouse_horticulture', 'cemetery', 'grave_yard', 'residential', 'garages', 'field', 'meadow', 'grass', 'allotments', 'forest', 'farmyard', 'farm', 'farmyard', 'recreation_ground', 'conservation', 'village_green', 'retail', 'industrial', 'railway', 'commercial', 'brownfield', 'landfill', 'greenfield', 'construction', 'wood') then landuse else null end)) as landuse,\n('leisure_' || (case when leisure in ('swimming_pool', 'playground', 'park', 'recreation_ground', 'common', 'garden', 'golf_course') then leisure else null end)) as leisure,\n('military_' || (case when military in ('barracks', 'danger_area') then military else null end)) as military,\n('natural_' || (case when \"natural\" in ('field','beach','desert','heath','mud','grassland','wood','sand','scrub') then \"natural\" else null end)) as \"natural\",\n('power_' || (case when power in ('station','sub_station','generator') then power else null end)) as power,\n('tourism_' || (case when tourism in ('attraction', 'camp_site', 'caravan_site', 'picnic_site', 'zoo') then tourism else null end)) as tourism,\n('highway_' || (case when highway in ('services', 'rest_area') then highway else null end)) as highway,\ncase when religion in ('christian','jewish') then religion else 'INT-generic'::text end as religion\n from planet_osm_polygon\n where landuse is not null\n or leisure is not null\n or aeroway in ('apron','aerodrome')\n or amenity in ('parking','university','college','school','hospital','kindergarten','grave_yard')\n or military in ('barracks','danger_area')\n or \"natural\" in ('field','beach','desert','heath','mud','grassland','wood','sand','scrub')\n or power in ('station','sub_station','generator')\n or tourism in ('attraction','camp_site','caravan_site','picnic_site','zoo')\n or highway in ('services','rest_area')\n order by z_order,way_area desc\n ) as landcover\n) as features",
"extent": "-20037508,-19929239,20037508,19929239",
"key_field": "",
"geometry_field": "",
Something went wrong with that request. Please try again.