Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the remaining fixtures #4

Closed
gravitystorm opened this issue Oct 5, 2016 · 14 comments
Closed

Convert the remaining fixtures #4

gravitystorm opened this issue Oct 5, 2016 · 14 comments

Comments

@gravitystorm
Copy link
Owner

@gravitystorm gravitystorm commented Oct 5, 2016

  • acls
  • changeset_comments
  • changesets_subscribers
  • changesets
  • changeset_tags
  • client_applications
  • countries
  • current_nodes
  • current_node_tags
  • current_relation_members
  • current_relations
  • current_relation_tags
  • current_way_nodes
  • current_ways
  • current_way_tags
  • friends
  • gps_points
  • gpx_files
  • gpx_file_tags
  • languages
  • messages
  • nodes
  • node_tags
  • note_comments
  • notes
  • redactions
  • relation_members
  • relations
  • relation_tags
  • user_blocks
  • user_preferences
  • user_roles
  • users
  • user_tokens
  • way_nodes
  • ways
  • way_tags

redactions blocked by nodes blocked by node_tags
changesets blocked by changeset_tags

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Feb 20, 2017

I've started working on the users fixtures. Given the size of this task I'm doing it one bit at a time, so the users factory is there, but many tests still use the fixtures.

When users is done, most parts of the site will be free from fixtures. The nodes/ways/relations stuff is rarely developed on so it can come afterwards.

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Feb 23, 2017

Jeez, this users factory thing is going to take a while. Before I started there were 828 calls to users() fixtures. 4 pull requests so far, but still 687 remaining.

grep -rn 'users(' test/

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Mar 5, 2017

Another PR, 620 calls remaining.

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Mar 9, 2017

Another PR today, 343 remaining.

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Mar 10, 2017

Two more PRs, one of which took a bit of headscratching to figure out. 272 remaining.

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Mar 15, 2017

PR this morning and 170 to go

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Mar 31, 2017

73 users fixtures remaining. I've had to branch out here and work on other factories, since many of the remaining uses are tied to e.g. the owner of the (changeset for the) node/way/relation in a particular test, and I can't replace the user without a factory for the node/way/relation. So the pace of users fixtures have slowed, but I'm chipping away at the other fixtures too.

@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Apr 25, 2017

OK, all the factories are now available and working correctly. Still 70 users fixtures remaining, but let's track things more widely. We're nearly in the endgame here:

nodes:      91
relations:  103
ways:       165
users:      70
changesets: 124

total: 553
@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Apr 27, 2017

nodes:      71
relations:  103
ways:       77
users:      51
changesets: 113

total: 415
@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented May 10, 2017

nodes:      34
relations:  84
ways:       45
users:      42
changesets: 96

total: 301
@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented May 17, 2017

nodes:      19
relations:  39
ways:       39
users:      30
changesets: 88

total: 215
@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented May 24, 2017

nodes:      19
relations:  39
ways:       39
users:      2
changesets: 62

total: 161
@gravitystorm
Copy link
Owner Author

@gravitystorm gravitystorm commented Jun 1, 2017

Done! 🍰 🎉 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.