Convert the remaining fixtures

[gravitystorm]

• acls
• changeset_comments
• changesets_subscribers
• changesets
• changeset_tags
• client_applications
• countries
• current_nodes
• current_node_tags
• current_relation_members
• current_relations
• current_relation_tags
• current_way_nodes
• current_ways
• current_way_tags
• friends
• gps_points
• gpx_files
• gpx_file_tags
• languages
• messages
• nodes
• node_tags
• note_comments
• notes
• redactions
• relation_members
• relations
• relation_tags
• user_blocks
• user_preferences
• user_roles
• users
• user_tokens
• way_nodes
• ways
• way_tags

redactions blocked by nodes blocked by node_tags
changesets blocked by changeset_tags

[gravitystorm]

Instructions are at https://gist.github.com/gravitystorm/80dc264af80c6bcac7e0cb110ae32256

[gravitystorm]

I've started working on the users fixtures. Given the size of this task I'm doing it one bit at a time, so the users factory is there, but many tests still use the fixtures.

When users is done, most parts of the site will be free from fixtures. The nodes/ways/relations stuff is rarely developed on so it can come afterwards.

[gravitystorm]

Jeez, this users factory thing is going to take a while. Before I started there were 828 calls to users() fixtures. 4 pull requests so far, but still 687 remaining.

grep -rn 'users(' test/

[gravitystorm]

Another PR, 620 calls remaining.

[gravitystorm]

Another PR today, 343 remaining.

[gravitystorm]

Two more PRs, one of which took a bit of headscratching to figure out. 272 remaining.

[gravitystorm]

PR this morning and 170 to go

[gravitystorm]

73 users fixtures remaining. I've had to branch out here and work on other factories, since many of the remaining uses are tied to e.g. the owner of the (changeset for the) node/way/relation in a particular test, and I can't replace the user without a factory for the node/way/relation. So the pace of users fixtures have slowed, but I'm chipping away at the other fixtures too.

[gravitystorm]

OK, all the factories are now available and working correctly. Still 70 users fixtures remaining, but let's track things more widely. We're nearly in the endgame here:

nodes:      91
relations:  103
ways:       165
users:      70
changesets: 124

total: 553

[gravitystorm]

nodes:      71
relations:  103
ways:       77
users:      51
changesets: 113

total: 415

[gravitystorm]

nodes:      34
relations:  84
ways:       45
users:      42
changesets: 96

total: 301

[gravitystorm]

nodes:      19
relations:  39
ways:       39
users:      30
changesets: 88

total: 215

[gravitystorm]

nodes:      19
relations:  39
ways:       39
users:      2
changesets: 62

total: 161

[gravitystorm]

Done! 🍰 🎉 🎈 ✅