New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope GravityView_Delete_Entry->process_delete() #624

Closed
dcavins opened this Issue Feb 9, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@dcavins
Copy link

dcavins commented Feb 9, 2016

Hi all-

GravityView is causing conflicts with BuddyPress because it is catching all URLs with ?action=delete in GravityView_Delete_Entry->process_delete() at the wp action.

Changing the conditional to

if ( $_GET('action') === 'delete' && isset( $_GET['entry_id'] ) )

would avoid my specific problem, but still relies on pretty generic query argument names. Since you know when this action needs to run (and I'm not even sure if this is a front-end or admin-only thing), I'm sure you've got a good idea of how to limit it with a conditional or, if it could run anywhere, making the action string more specific.

Here's an example of a url that process_delete() attempts to catch (and then drops to WP's bad nonce "are you sure you want to do that" screen):
http://mywebsite.org/members/member-name/notifications/unread/?action=delete&notification_id=18740&_wpnonce=123456789ab

Thanks!

┆Issue is synchronized with this Asana task

zackkatz added a commit that referenced this issue Feb 9, 2016

@zackkatz

This comment has been minimized.

Copy link
Member

zackkatz commented Feb 9, 2016

@dcavins Good catch, thanks! Please test the patch and let me know if it works for you.

@zackkatz zackkatz added this to the 1.16.2 milestone Feb 9, 2016

@zackkatz zackkatz self-assigned this Feb 9, 2016

@dcavins

This comment has been minimized.

Copy link

dcavins commented Feb 9, 2016

Hi Zack-

Yep, that works in my case.

Thanks for your quick response!

-David

@dcavins dcavins closed this Feb 9, 2016

@zackkatz

This comment has been minimized.

Copy link
Member

zackkatz commented Feb 15, 2016

@dcavins - Just released 1.16.2, which includes this update. Thanks again for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment