feat(check-extension): leverage .github/check-extension.json if it ex…#269
Merged
Conversation
b90534d to
0bf08ef
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
check-extension.yamlconsumes the caller-suppliedinputs.matrixdirectly. Every matrix-using job (unit-test-extension,compile-extension,integration_test) is wired to the same unfiltered matrix, andintegration_testends up booting every service container the matrix carries — includingnginxandphp-fpm, neither of which the PHPUnit integration suite ever talks to. There is also no caller-facing way to skip an individual check per project.Fixes: N/A
What is the new behavior?
compute_resolvedorchestration job tocheck-extension.yamlthat callsresolve-check-config@mainwithkind: extensionandmatrix: ${{ inputs.matrix }}.unit-test-extension,compile-extension, andintegration_test:needs: compute_resolvedfromJSON(needs.compute_resolved.outputs.resolved)['<job>'].enabled != false, so callers can disable a check by adding it to.github/check-extension.json.strategy.matrixfromresolved['<job>'].matrix, which already has each entry'sservicesmap filtered to the tiers that job needs.coding-standardandcompute_latest_matrixare intentionally left alone — they run on a separate latest-version matrix and have no service surface.kinds/extension.tsdeclaresintegration_testwithrequiredServices: ['db', 'search', 'queue', 'cache']— explicitly excludes thewebtier so nginx + php-fpm are never started for integration tests, regardless of caller config.docs/workflows/check-extension.mdgets a Configuration section documenting.github/check-extension.jsonwith a$schema-referenced JSON example for editor autocompletion / validation.Does this PR introduce a breaking change?
check-extension.yaml's public inputs and secrets are unchanged. Callers that don't ship a.github/check-extension.jsoncontinue to run all four checks. Theintegration_testweb-tier removal is a behavior improvement (faster, fewer resources) — any caller relying on nginx/php-fpm insideintegration_testwas already in undefined territory since the PHPUnit suite doesn't drive HTTP.Other information
resolve-check-configaction already onmain(introduced in the prior check-store PR).requiredServicesis the floor for a job's tier set: callers can ADD tiers viaservices: [...], but cannot drop the required ones. This is what makes the integration_test web-tier exclusion enforceable.