New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs are not URL-encoded breaking the markdown rendering in Mattermost #54

Closed
svnk opened this Issue Aug 18, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@svnk
Copy link

svnk commented Aug 18, 2017

We use the plugin in mattermost and have messages like this:

*New message in Graylog stream [Foo Exceptions]
(https://graylog/streams/58311e2b2ab79c080136c1d9/messages?q=*&rangetype=relative&relative=3600)*:

the star () in q= is seen as ending the italic section leaving the message rendered as

New message in Graylog stream [Foo Exceptions](https://graylog/streams/58311e2b2ab79c080136c1d9/messages?q= &rangetype=relative&relative=3600)*:

(w/o the blank. the github markdown renderer is smarter than the markdown renderer of mattermost.)

If the URL is URL-encoded, this can be avoided.

@Aenima4six2

This comment has been minimized.

Copy link
Collaborator

Aenima4six2 commented Nov 22, 2017

I'll take a look at this.

@towolf

This comment has been minimized.

Copy link

towolf commented Nov 29, 2017

Actually, with #60 in, the asterisk should be gone.

Not that this means, that this Issue is not relevant. But the newest build should work around it.

@towolf

This comment has been minimized.

Copy link

towolf commented Nov 29, 2017

Ah, scratch that, there are two links in the message, and the second one is still broken.

mseitner pushed a commit to mseitner/graylog-plugin-slack that referenced this issue Dec 1, 2017

@towolf

This comment has been minimized.

Copy link

towolf commented Dec 5, 2017

Please merge PR #63 @Aenima4six2, tested here successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment