New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single quotes in username are bad #1005

Closed
magicalbob opened this Issue Dec 12, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@magicalbob

magicalbob commented Dec 12, 2014

Adding a user with a single quote in username is accepted by graylog2-web-interface, but you can't log in with that user and you can't delete the user.

Add

        if (username.indexOf("'") > -1 ) {
          validationFailure( createUsernameField, "Username can't have quotes.");
          domElement.setCustomValidity('Username cannot have quotes.');
        } else {
          $.ajax({

.
.
.

          });
        }

to app/assets/javascripts/main.js stops anyone from doing something stupid like putting a single quote in a username.

I'm a newb and haven't worked out how to commit changes .......

@kroepke kroepke added bug users labels Jan 12, 2015

@kroepke kroepke added this to the 0.93 milestone Jan 12, 2015

@kroepke kroepke self-assigned this Jan 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment