New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages when an input can't start #1056

Closed
edmundoa opened this Issue Jan 21, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Jan 21, 2015

The text messages when an input can't be started should be a bit more human readable, at least remove the duplication. Here are a couple of examples:

  • Graylog2 Radio AMQP input:

    org.graylog2.plugin.inputs.MisfireException: Could not launch AMQP consumer., Could not launch AMQP consumer., foo

  • Syslog UDP:

    org.graylog2.plugin.inputs.MisfireException: org.jboss.netty.channel.ChannelException: Failed to bind to: /0.0.0.0:1514, org.jboss.netty.channel.ChannelException: Failed to bind to: /0.0.0.0:1514, Failed to bind to: /0.0.0.0:1514, Address already in use

@edmundoa edmundoa added the usability label Jan 21, 2015

@edmundoa edmundoa added this to the 1.0.0 milestone Jan 21, 2015

@edmundoa edmundoa self-assigned this Jan 23, 2015

@kroepke

This comment has been minimized.

Contributor

kroepke commented Jan 23, 2015

@edmundoa check if we already have a method like "getMostSpecificCause" for an exception.
Elasticsearch has a helper method like that, and I vaguely remember having implemented this for graylog at some point, too.
Usually the message of that is what you want to display (eg "Address already in use")

edmundoa added a commit that referenced this issue Jan 26, 2015

@edmundoa

This comment has been minimized.

Member

edmundoa commented Jan 26, 2015

@kroepke Thank you for the hint! In the end I could only find that method on the rest client module, which is not a dependency of the shared module, so I created a utility class in shared to help doing some common things with exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment