New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output configuration fields with IS_PASSWORD attribute are not obfuscated in stream output list #1066

Closed
lennartkoopmann opened this Issue Jan 24, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@lennartkoopmann
Contributor

lennartkoopmann commented Jan 24, 2015

The global output list in /system does this, but the output list of a stream does not

@lennartkoopmann lennartkoopmann added this to the 1.0.0 milestone Jan 24, 2015

@lennartkoopmann

This comment has been minimized.

Contributor

lennartkoopmann commented Jan 24, 2015

The global output list is built like this:

List<Output> outputs = outputService.list();

... and the stream output list is built like this:

List<Output> outputs = streamService.getOutputs(streamId);

I guess the global list is applying the obfuscation and the second one is not. Cannot fix myself right now because my local IDE setup for the web interface is not loading the rest module plugins or wherever the services are coming from nowadays. :) E_NOCOREDEVELOPER

@dennisoelkers

This comment has been minimized.

Contributor

dennisoelkers commented Jan 27, 2015

joschi referenced this issue in Graylog2/graylog2-server Jun 2, 2015

Quite some effort for a (still ugly) solution to mask passwords.
In the long run we need to store all entities configurations in typed
objects which are also used to generate the configuration request, so
everything is in one place. For now the filtering logic is extracted to
a separate helper class and return types for both resources are unified.

Fixes #1066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment