Skip to content
This repository has been archived by the owner. It is now read-only.

Output configuration fields with IS_PASSWORD attribute are not obfuscated in stream output list #1066

Closed
lennartkoopmann opened this issue Jan 24, 2015 · 2 comments
Milestone

Comments

@lennartkoopmann
Copy link
Contributor

@lennartkoopmann lennartkoopmann commented Jan 24, 2015

The global output list in /system does this, but the output list of a stream does not

@lennartkoopmann lennartkoopmann added this to the 1.0.0 milestone Jan 24, 2015
@lennartkoopmann
Copy link
Contributor Author

@lennartkoopmann lennartkoopmann commented Jan 24, 2015

The global output list is built like this:

List<Output> outputs = outputService.list();

... and the stream output list is built like this:

List<Output> outputs = streamService.getOutputs(streamId);

I guess the global list is applying the obfuscation and the second one is not. Cannot fix myself right now because my local IDE setup for the web interface is not loading the rest module plugins or wherever the services are coming from nowadays. :) E_NOCOREDEVELOPER

Loading

@dennisoelkers
Copy link
Contributor

@dennisoelkers dennisoelkers commented Jan 27, 2015

Loading

joschi referenced this issue in Graylog2/graylog2-server Jun 2, 2015
In the long run we need to store all entities configurations in typed
objects which are also used to generate the configuration request, so
everything is in one place. For now the filtering logic is extracted to
a separate helper class and return types for both resources are unified.

Fixes #1066
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants