Skip to content
This repository has been archived by the owner. It is now read-only.

Nodes overview page is not showing message journal usage #1083

Closed
lennartkoopmann opened this issue Jan 26, 2015 · 7 comments
Closed

Nodes overview page is not showing message journal usage #1083

lennartkoopmann opened this issue Jan 26, 2015 · 7 comments
Assignees
Milestone

Comments

@lennartkoopmann
Copy link
Contributor

@lennartkoopmann lennartkoopmann commented Jan 26, 2015

Was there a reason not to show the message journal usage on the nodes overview page? It was showing the cache utilization in earlier versions to indicate quickly if messages were queuing up or not and I think this was helpful to people.

screen shot 2015-01-26 at 14 03 33

@lennartkoopmann lennartkoopmann added this to the 1.0.0 milestone Jan 26, 2015
@kroepke
Copy link
Contributor

@kroepke kroepke commented Jan 26, 2015

The only reason was that the Chief UX Officer (me) did it over Christmas.
Let's add in 1.0.1?
On Jan 26, 2015 9:05 PM, "Lennart Koopmann" notifications@github.com
wrote:

Was there a reason not to show the message journal usage on the nodes
overview page? It was showing the cache utilization in earlier versions to
indicate quickly if messages were queuing up or not and I think this was
helpful to people.

[image: screen shot 2015-01-26 at 14 03 33]
https://cloud.githubusercontent.com/assets/35022/5907413/6007112e-a564-11e4-91df-ac28f8eed4a4.png


Reply to this email directly or view it on GitHub
#1083.

@lennartkoopmann lennartkoopmann added this to the 1.0.1 milestone Jan 26, 2015
@lennartkoopmann lennartkoopmann removed this from the 1.0.0 milestone Jan 26, 2015
@lennartkoopmann
Copy link
Contributor Author

@lennartkoopmann lennartkoopmann commented Jan 26, 2015

Makes sense! Set milestone to 1.0.1.

@bernd
Copy link
Contributor

@bernd bernd commented Mar 4, 2015

Fixed by #1146

@bernd bernd closed this Mar 4, 2015
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Mar 9, 2015

The changes we made to fix this issue broke the journal information on the node page. Working on a fix for it.

@edmundoa edmundoa reopened this Mar 9, 2015
@edmundoa edmundoa closed this Mar 9, 2015
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Mar 9, 2015

The problem was that we were using the same CSS class for the DOM elements in the nodes overview page and node page, so the Javascript code was applying to both.

@bernd
Copy link
Contributor

@bernd bernd commented Mar 9, 2015

Ugh, thanks. Bad me for not testing this. 😞

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Mar 9, 2015

Was hard to catch, I was also reviewing it and didn't see it 😕

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants