New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes overview page is not showing message journal usage #1083

Closed
lennartkoopmann opened this Issue Jan 26, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@lennartkoopmann
Contributor

lennartkoopmann commented Jan 26, 2015

Was there a reason not to show the message journal usage on the nodes overview page? It was showing the cache utilization in earlier versions to indicate quickly if messages were queuing up or not and I think this was helpful to people.

screen shot 2015-01-26 at 14 03 33

@lennartkoopmann lennartkoopmann added this to the 1.0.0 milestone Jan 26, 2015

@kroepke

This comment has been minimized.

Contributor

kroepke commented Jan 26, 2015

The only reason was that the Chief UX Officer (me) did it over Christmas.
Let's add in 1.0.1?
On Jan 26, 2015 9:05 PM, "Lennart Koopmann" notifications@github.com
wrote:

Was there a reason not to show the message journal usage on the nodes
overview page? It was showing the cache utilization in earlier versions to
indicate quickly if messages were queuing up or not and I think this was
helpful to people.

[image: screen shot 2015-01-26 at 14 03 33]
https://cloud.githubusercontent.com/assets/35022/5907413/6007112e-a564-11e4-91df-ac28f8eed4a4.png


Reply to this email directly or view it on GitHub
#1083.

@lennartkoopmann lennartkoopmann modified the milestones: 1.0.1, 1.0.0 Jan 26, 2015

@lennartkoopmann

This comment has been minimized.

Contributor

lennartkoopmann commented Jan 26, 2015

Makes sense! Set milestone to 1.0.1.

@kroepke kroepke added the usability label Jan 27, 2015

bernd added a commit that referenced this issue Mar 3, 2015

bernd added a commit that referenced this issue Mar 4, 2015

@bernd bernd self-assigned this Mar 4, 2015

@bernd

This comment has been minimized.

Contributor

bernd commented Mar 4, 2015

Fixed by #1146

@bernd bernd closed this Mar 4, 2015

@edmundoa

This comment has been minimized.

Member

edmundoa commented Mar 9, 2015

The changes we made to fix this issue broke the journal information on the node page. Working on a fix for it.

@edmundoa edmundoa reopened this Mar 9, 2015

edmundoa added a commit that referenced this issue Mar 9, 2015

@edmundoa edmundoa closed this Mar 9, 2015

@edmundoa

This comment has been minimized.

Member

edmundoa commented Mar 9, 2015

The problem was that we were using the same CSS class for the DOM elements in the nodes overview page and node page, so the Javascript code was applying to both.

@bernd

This comment has been minimized.

Contributor

bernd commented Mar 9, 2015

Ugh, thanks. Bad me for not testing this. 😞

@edmundoa

This comment has been minimized.

Member

edmundoa commented Mar 9, 2015

Was hard to catch, I was also reviewing it and didn't see it 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment