New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing output plugin breaks Output listing #1185

Closed
dennisoelkers opened this Issue Mar 25, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@dennisoelkers
Contributor

dennisoelkers commented Mar 25, 2015

Steps to reproduce:

  1. Load external plugin supplying output type
  2. Create output using this output type
  3. Unload plugin
  4. Go to System/Outputs in Web Interface

Expected Result:
Listing of configured outputs

Actual Result:
500 due to NPE

What is happening here is that displaying the configuration of an output requires the requested configuration of that output type to be requested from the server. This returns a list of required configurations which lacks that of the configured output type.

@dennisoelkers dennisoelkers added the bug label Mar 25, 2015

@dennisoelkers dennisoelkers added this to the 1.1.0 milestone Mar 25, 2015

@dennisoelkers dennisoelkers self-assigned this Mar 25, 2015

@dennisoelkers

This comment has been minimized.

Contributor

dennisoelkers commented Jun 1, 2015

With the current version the output listing does not break anymore, but there is no indication the plugin is not loaded and it is not possible to edit the output.

@joschi

This comment has been minimized.

Contributor

joschi commented Jun 2, 2015

This behavior is now at least consistent with inputs or alarm callbacks being contributed by plugins.

We should decide how we want to handle these cases (hide components with non-existing backend or simply hide them and print a warning in the Graylog server logs) and implement that in a later version.

@dennisoelkers

This comment has been minimized.

Contributor

dennisoelkers commented Jun 2, 2015

I think hiding is the worst option. We should display them in the web if with a hint that the plugin is not loading and the entity's functionality is limited, but give the option to delete them.

dennisoelkers added a commit that referenced this issue Jun 2, 2015

Showing warning and disabling edit button for output if plugin is mis…
…sing.

Also adding spinner in output list during loading.

Fixes #1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment