Skip to content
This repository has been archived by the owner. It is now read-only.

Indication when expanding all messages #1283

Closed
edmundoa opened this issue May 18, 2015 · 4 comments
Closed

Indication when expanding all messages #1283

edmundoa opened this issue May 18, 2015 · 4 comments
Milestone

Comments

@edmundoa
Copy link
Member

@edmundoa edmundoa commented May 18, 2015

When the user clicks on the expand all messages button, we should display a spinner or indication that we are doing it, as it may take some time.

@edmundoa edmundoa added this to the 1.1.0 milestone May 18, 2015
@kroepke
Copy link
Contributor

@kroepke kroepke commented May 20, 2015

Turns out that this is slightly tricky, because the state is already being updated, so even rendering the spinner is slow because we need to render the entire table at the same time.

We'd need to wait until expanding the messages somehow, but every option I came up with is awkward.

@pkoraca
Copy link

@pkoraca pkoraca commented May 21, 2015

Hello,

I have similar issue when I click Expand all messages - browser (tried Chrome and Firefox) is unresponsive. Firefox says there is issue with app-a151c8f7.js:18.

Also, CPU utilization on my laptop goes to 100%.

Cheers

@kroepke
Copy link
Contributor

@kroepke kroepke commented May 21, 2015

Well there's tons of javascript that needs to be executed when rendering the 100 messages.
We'll investigate whether we can do something about it. Worst case, we have to remove that button, I guess.

edmundoa added a commit that referenced this issue May 25, 2015
As rendering may take a while, we show a loading indicator while we
update the DOM. Refs #1283
@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented May 26, 2015

This was fixed in #1329

@edmundoa edmundoa closed this May 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants