New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indication when expanding all messages #1283

Closed
edmundoa opened this Issue May 18, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@edmundoa
Member

edmundoa commented May 18, 2015

When the user clicks on the expand all messages button, we should display a spinner or indication that we are doing it, as it may take some time.

@edmundoa edmundoa added this to the 1.1.0 milestone May 18, 2015

@kroepke

This comment has been minimized.

Contributor

kroepke commented May 20, 2015

Turns out that this is slightly tricky, because the state is already being updated, so even rendering the spinner is slow because we need to render the entire table at the same time.

We'd need to wait until expanding the messages somehow, but every option I came up with is awkward.

@pkoraca

This comment has been minimized.

pkoraca commented May 21, 2015

Hello,

I have similar issue when I click Expand all messages - browser (tried Chrome and Firefox) is unresponsive. Firefox says there is issue with app-a151c8f7.js:18.

Also, CPU utilization on my laptop goes to 100%.

Cheers

@kroepke

This comment has been minimized.

Contributor

kroepke commented May 21, 2015

Well there's tons of javascript that needs to be executed when rendering the 100 messages.
We'll investigate whether we can do something about it. Worst case, we have to remove that button, I guess.

edmundoa added a commit that referenced this issue May 25, 2015

Load spinner on message details while rendering
As rendering may take a while, we show a loading indicator while we
update the DOM. Refs #1283
@edmundoa

This comment has been minimized.

Member

edmundoa commented May 26, 2015

This was fixed in #1329

@edmundoa edmundoa closed this May 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment