New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll on actions #1284

Closed
edmundoa opened this Issue May 18, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented May 18, 2015

When clicking on the "add to search" button, adding statistics, adding field graphs, or adding quick values, we should show some indication that we added some elements into de page, and maybe scroll to them.

@edmundoa edmundoa added this to the 1.1.0 milestone May 18, 2015

@edmundoa edmundoa self-assigned this May 28, 2015

edmundoa added a commit that referenced this issue May 28, 2015

edmundoa added a commit that referenced this issue May 28, 2015

edmundoa added a commit that referenced this issue May 28, 2015

Scroll to the element that displayed the indicator
We need to use a different hint element to avoid conflicts with main.js

Refs #1284

edmundoa added a commit that referenced this issue May 28, 2015

Do not show scroll hints for pinned field graphs
Otherwise the user may get scroll hints for all field graphs when the
page is reloaded.

That implies that we need to fix the way we handled the events from the
old fieldcharts.js

Refs #1284
@edmundoa

This comment has been minimized.

Member

edmundoa commented May 28, 2015

Fixed with cb57495, 2ced1d7, 0136e8b, 71559b8, and e053fd0.

@edmundoa edmundoa closed this May 28, 2015

@kroepke

This comment has been minimized.

Contributor

kroepke commented May 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment