Skip to content
This repository has been archived by the owner. It is now read-only.

Fields Sidebar Cutoff (1.1.RC3) #1410

Closed
NickMeves opened this issue Jun 2, 2015 · 8 comments
Closed

Fields Sidebar Cutoff (1.1.RC3) #1410

NickMeves opened this issue Jun 2, 2015 · 8 comments
Assignees
Labels
Milestone

Comments

@NickMeves
Copy link

@NickMeves NickMeves commented Jun 2, 2015

For large lists of viewable fields, the bottom of the left fields sidebar is cutoff. The lower entries are inaccessible and the sidebar is unscrollable. Both with smaller window size (but larger than mobile responsive CSS) and with full screen.

First noticed in 1.1.RC1. Still persistent in 1.1.RC3.

OS: Windows. Browser: Firefox

@kroepke kroepke added this to the 1.1.1 milestone Jun 3, 2015
@kroepke kroepke added the bug label Jun 3, 2015
@kroepke
Copy link
Contributor

@kroepke kroepke commented Jun 3, 2015

@edmundoa can you please do a quick check and if easy to fix we'll see if we can pull this into 1.1.0?

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jun 3, 2015

Hi,

I'm looking into it using the latest Firefox (38.0.5) version on Windows 7 and I can't reproduce the issue. Could you please give us some more details @NickMeves? Browser/OS versions, and any errors that you may see on your browser's Javascript console would be really helpful.

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jun 3, 2015

I just tried to reproduce the issue on Windows 8.1 with the same results.

@NickMeves
Copy link
Author

@NickMeves NickMeves commented Jun 3, 2015

Windows 7
Firefox ESR 31.5 (In the Corporate setting we will frequently be many versions behind current releases)

I'll dig into JS consoles to see if anything is flagging. This occurs with searches that have tons of fields in the sidebar (30+)

@NickMeves
Copy link
Author

@NickMeves NickMeves commented Jun 3, 2015

Pulled it up in Firefox and Safari from my Mac side - Looks great! I see other things going wrong on the older Firefox side with CSS styling though in addition to the left sidebar not being able to figure out the window height dynamically.

@NickMeves
Copy link
Author

@NickMeves NickMeves commented Jun 3, 2015

No Matter how I resize the page, this element isn't updating on the Windows 7, Firefox 31.5 side:

div data-reactid=".2.0.0.0.1" style="max-height:1000px;overflow-y:scroll;"

That max height is dynamic and shifting as I resize things on the Mac side with Firefox and Safari (which I assume is the intended functionality).

Maybe if resizing isn't doable for older browsers have the default max-height be lower than 1000px (500px maybe?) so the sidebar is at least viewable when it won't resize?

@kroepke
Copy link
Contributor

@kroepke kroepke commented Jun 3, 2015

We'll try to get a proper fix in for 1.1.1, if it's too difficult I agree
that otherwise a fallback to a fixed max-height might be the best option.
On Jun 3, 2015 7:13 PM, "NickMeves" notifications@github.com wrote:

No Matter how I resize the page, this element isn't updating on the
Windows 7, Firefox 31.5 side:

That max height is dynamic and shifting as I resize things on the Mac
side with Firefox and Safari (which I assume is the intended functionality).

Maybe if resizing isn't doable for older browsers have the default
max-height be lower than 1000px (500px maybe?) so the sidebar is at least
viewable when it won't resize?


Reply to this email directly or view it on GitHub
#1410 (comment)
.

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jun 3, 2015

I could reproduce the issue using Firefox 31.7 esr. As @kroepke said, let's try to fix the height calculation on 1.1.1.

@edmundoa edmundoa closed this in 1c67964 Jun 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants