New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto created search syntax must use quotes for values with whitespaces in them #1448

Closed
lennartkoopmann opened this Issue Jun 8, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@lennartkoopmann
Contributor

lennartkoopmann commented Jun 8, 2015

A user reported that when you click the "create search" button for a quickvalues value it does not take whitespaces in account:

capture

This will most probably be the case for all parts of the web interface where you can add values to the current search query. The old non-react behavior was taking care of this by just checking if there is whitespaces in the value or not and we never heard of issues with that so that should be a suitable solution.

@lennartkoopmann lennartkoopmann added the bug label Jun 8, 2015

@lennartkoopmann lennartkoopmann added this to the 1.1.2 milestone Jun 8, 2015

@kroepke

This comment has been minimized.

Contributor

kroepke commented Jun 8, 2015

The old code should still be in there to call, probably simply not being included right now.

@edmundoa edmundoa self-assigned this Jun 8, 2015

@edmundoa edmundoa closed this in 50724d2 Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment