Skip to content
This repository has been archived by the owner. It is now read-only.

Unable to unpause streams, dispite editing permissions #1456

Closed
aethos opened this issue Jun 8, 2015 · 3 comments
Closed

Unable to unpause streams, dispite editing permissions #1456

aethos opened this issue Jun 8, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@aethos
Copy link

@aethos aethos commented Jun 8, 2015

I am a "Reader" user, as labeled in the list of users. I have view and editing permissions to a stream, but I am unable to unpause the stream. This seems like an issue because although I am not able to unpause the stream, I am able to delete it.

@aethos aethos changed the title Unable to unpause streams, dissipate editing permissions Unable to unpause streams, dispite editing permissions Jun 8, 2015
@reighnman
Copy link

@reighnman reighnman commented Jun 8, 2015

If editors can delete a stream they should be able to pause/unpause, if not they shouldn't have delete permissions either.

@kroepke
Copy link
Contributor

@kroepke kroepke commented Jun 8, 2015

This seems like a bug, editing permissions are supposed to grant all of the mentioned actions or none of them if only view permissions are granted.

@kroepke kroepke added the bug label Jun 8, 2015
@kroepke kroepke added this to the 1.1.2 milestone Jun 8, 2015
@dennisoelkers dennisoelkers self-assigned this Jun 9, 2015
@florianpopp
Copy link

@florianpopp florianpopp commented Jun 9, 2015

As a read-only user I am also not able to manage outputs and alerts. Seems to be the same problem.

bildschirmfoto 2015-06-09 um 14 55 06

bildschirmfoto 2015-06-09 um 14 56 13

@kroepke kroepke assigned kroepke and unassigned dennisoelkers Jun 10, 2015
kroepke added a commit to Graylog2/graylog2-server that referenced this issue Jun 10, 2015
extend the permission check methods to check for an array of possible permissions

this is in addition to the streams:changestate permission and requires the corresponding web-interface PR to be visible

fixes graylog-labs/graylog2-web-interface#1456
kroepke added a commit to Graylog2/graylog2-server that referenced this issue Jun 10, 2015
don't try to be too clever and actually add tests

fixes graylog-labs/graylog2-web-interface#1456
dennisoelkers added a commit that referenced this issue Jun 10, 2015
allow users with stream edit permissions to pause/resume streams

Fixes #1456
@kroepke kroepke closed this in 97aae7f Jun 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants