New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to unpause streams, dispite editing permissions #1456

Closed
aethos opened this Issue Jun 8, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@aethos

aethos commented Jun 8, 2015

I am a "Reader" user, as labeled in the list of users. I have view and editing permissions to a stream, but I am unable to unpause the stream. This seems like an issue because although I am not able to unpause the stream, I am able to delete it.

@aethos aethos changed the title from Unable to unpause streams, dissipate editing permissions to Unable to unpause streams, dispite editing permissions Jun 8, 2015

@reighnman

This comment has been minimized.

reighnman commented Jun 8, 2015

If editors can delete a stream they should be able to pause/unpause, if not they shouldn't have delete permissions either.

@kroepke

This comment has been minimized.

Contributor

kroepke commented Jun 8, 2015

This seems like a bug, editing permissions are supposed to grant all of the mentioned actions or none of them if only view permissions are granted.

@kroepke kroepke added the bug label Jun 8, 2015

@kroepke kroepke added this to the 1.1.2 milestone Jun 8, 2015

@dennisoelkers dennisoelkers self-assigned this Jun 9, 2015

@florianvolle

This comment has been minimized.

florianvolle commented Jun 9, 2015

As a read-only user I am also not able to manage outputs and alerts. Seems to be the same problem.

bildschirmfoto 2015-06-09 um 14 55 06

bildschirmfoto 2015-06-09 um 14 56 13

@kroepke kroepke assigned kroepke and unassigned dennisoelkers Jun 10, 2015

kroepke added a commit to Graylog2/graylog2-server that referenced this issue Jun 10, 2015

allow users with stream:edit permissions to pause/resume streams
extend the permission check methods to check for an array of possible permissions

this is in addition to the streams:changestate permission and requires the corresponding web-interface PR to be visible

fixes graylog-labs/graylog2-web-interface#1456

kroepke added a commit to Graylog2/graylog2-server that referenced this issue Jun 10, 2015

fix permission check with multiple permissions
don't try to be too clever and actually add tests

fixes graylog-labs/graylog2-web-interface#1456

dennisoelkers added a commit that referenced this issue Jun 10, 2015

Merge pull request #1468 from Graylog2/fix-issue-1456-stream-pause
allow users with stream edit permissions to pause/resume streams

Fixes #1456

@kroepke kroepke closed this in 97aae7f Jun 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment