New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick values add to dashboard state problem #1603

Closed
bernd opened this Issue Sep 15, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@bernd
Contributor

bernd commented Sep 15, 2015

There seems to be a state problem for the "Add to dashboard" feature in the quick values widget.

Steps to reproduce:

  1. Open quick values for a field
  2. Click "Add to dashboard" and select dashboard
  3. Check title in modal
  4. Close modal
  5. Open quick values for another field
  6. Click "Add to dashboard" and select dashboard
  7. Check title in modal --> Title is the one for the previous field

This only seems to happen if you do not "dismiss" the quick values before opening the quick values for another field.

@bernd bernd added the bug label Sep 15, 2015

@edmundoa edmundoa added this to the 1.2.1 milestone Sep 15, 2015

@edmundoa edmundoa self-assigned this Sep 15, 2015

@edmundoa edmundoa closed this in c6b9bc7 Sep 16, 2015

edmundoa added a commit that referenced this issue Sep 16, 2015

Do not store in the state widget default title
On the widget creation modal, we should not cache the widget title, as
changes in props may affect the default title.

Fixes #1603

(cherry picked from commit c6b9bc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment