New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in indices page don't show confirmation dialogs #1691

Closed
edmundoa opened this Issue Nov 18, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@edmundoa
Member

edmundoa commented Nov 18, 2015

In 1.3, links to recalculate index range, close index, and delete index do not show confirmation dialogs, even if we intend to do so by setting the data-confirm attribute on those links.

@edmundoa edmundoa self-assigned this Nov 18, 2015

@edmundoa edmundoa added this to the 1.3.0 milestone Nov 18, 2015

edmundoa added a commit that referenced this issue Nov 18, 2015

Show confirmations on dinamically loaded DOM
When part of the DOM is loaded dynamically, we should still rely on
`data-confirm` attributes to show confirmation dialogs.

Fixes #1691
@edmundoa

This comment has been minimized.

Member

edmundoa commented Nov 18, 2015

Fixed with d01e8f9.

@edmundoa edmundoa closed this Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment