Skip to content
This repository has been archived by the owner. It is now read-only.

Links in indices page don't show confirmation dialogs #1691

Closed
edmundoa opened this issue Nov 18, 2015 · 1 comment
Closed

Links in indices page don't show confirmation dialogs #1691

edmundoa opened this issue Nov 18, 2015 · 1 comment
Assignees
Milestone

Comments

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Nov 18, 2015

In 1.3, links to recalculate index range, close index, and delete index do not show confirmation dialogs, even if we intend to do so by setting the data-confirm attribute on those links.

@edmundoa edmundoa self-assigned this Nov 18, 2015
@edmundoa edmundoa added this to the 1.3.0 milestone Nov 18, 2015
edmundoa added a commit that referenced this issue Nov 18, 2015
When part of the DOM is loaded dynamically, we should still rely on
`data-confirm` attributes to show confirmation dialogs.

Fixes #1691
@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Nov 18, 2015

Fixed with d01e8f9.

@edmundoa edmundoa closed this Nov 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant