This repository has been archived by the owner on Jan 8, 2019. It is now read-only.
Refactor index ranges handling #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -337,11 +337,11 @@ protected String determineHistogramResolution(final SearchResult searchResult) { | |||
| Collections.sort(usedIndices, new Comparator<IndexRangeSummary>() { | |||
| @Override | |||
| public int compare(IndexRangeSummary o1, IndexRangeSummary o2) { | |||
| return o1.start().compareTo(o2.start()); | |||
| return o1.begin().compareTo(o2.begin()); | |||
There was a problem hiding this comment.
@kroepke Are you sure this is correct and what you want? The "start()" method maps to the "end()" method of the new index range class.
There was a problem hiding this comment.
Yeah, you're right, this should be end() instead due to the funny naming confusion.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes related to Graylog2/graylog2-server#1274.