Skip to content
This repository has been archived by the owner. It is now read-only.

Stacked charts #1513

Merged
merged 15 commits into from Jul 13, 2015
Merged

Stacked charts #1513

merged 15 commits into from Jul 13, 2015

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jul 2, 2015

These changes make possible to create and view stacked charts on the web interface. To create a new stacked widget you need to put together some widgets on the search results page and then add them to a dashboard.

Known issues: custom interpolation is not supported by c3, and at the moment is not possible to edit the series data. I will work on those issues once the changes are in master.

Thanks!

@edmundoa edmundoa added this to the 1.2.0 milestone Jul 2, 2015
@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Jul 3, 2015

Forgot to mention that this depends on Graylog2/graylog2-server#1284, that's why travis is now failing :)

case FIELD_CHART:
Map<String, Object> config = new HashMap<String, Object>() {{
final Map<String, Object> config = new HashMap<String, Object>() {{
Copy link
Contributor

@joschi joschi Jul 3, 2015

Maybe use ImmutableMap.of() instead of the anonymous HashMap class? This will only work if none of the values is null.

Copy link
Member Author

@edmundoa edmundoa Jul 3, 2015

The frontend should provide all those values when creating the widget without the user filling them in, so I think we can use the ImmutableMap.

@joschi joschi self-assigned this Jul 3, 2015
@joschi
Copy link
Contributor

@joschi joschi commented Jul 13, 2015

LGTM. 👍

joschi added a commit that referenced this issue Jul 13, 2015
@joschi joschi merged commit 0cf7d47 into master Jul 13, 2015
2 checks passed
@joschi joschi deleted the stacked-charts branch Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants