Skip to content
This repository has been archived by the owner. It is now read-only.

React dashboards #1550

Merged
merged 9 commits into from Aug 14, 2015
Merged

React dashboards #1550

merged 9 commits into from Aug 14, 2015

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Aug 6, 2015

Port of the dashboard list page to React. I had to do some yak-shaving in the DashboardStore, as we need to expose the list of editable dashboards in other components.

@edmundoa edmundoa added this to the 1.2.0 milestone Aug 6, 2015
@dennisoelkers dennisoelkers self-assigned this Aug 10, 2015
const EditDashboardModalTrigger = require('./EditDashboardModalTrigger');
const PermissionsMixin = require('../../util/PermissionsMixin');

const DashboardStore = require('../../stores/dashboard/DashboardStore');
Copy link
Contributor

@dennisoelkers dennisoelkers Aug 11, 2015

Could you please use module imports? That way imports are theoretically independent of the module loader user.

Copy link
Member Author

@edmundoa edmundoa Aug 11, 2015

Makes sense, will change that 👍

@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Aug 12, 2015

All issues should be addressed with the latest changes 😄

dennisoelkers added a commit that referenced this issue Aug 14, 2015
@dennisoelkers dennisoelkers merged commit 5bb9c07 into master Aug 14, 2015
2 checks passed
@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Aug 14, 2015

Thank you for reviewing @dennisoelkers! 👍

@edmundoa edmundoa deleted the react-dashboards branch Aug 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants