New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Stream OR-Operator UI #1552

Merged
merged 6 commits into from Aug 14, 2015

Conversation

Projects
None yet
2 participants
@dennisoelkers
Contributor

dennisoelkers commented Aug 11, 2015

This PR adds a simple UI for the matching type of stream. Configuration is done inline in the stream rules editor by adding a simple dropdown in a verbal description of the matching logic. In the streams list, the stream type is indicated in the verbal description of the stream rules summary.

@edmundoa edmundoa self-assigned this Aug 11, 2015

@edmundoa edmundoa added this to the 1.2.0 milestone Aug 11, 2015

static propTypes = {
stream: PropTypes.object.isRequired,
onChange: PropTypes.func.isRequired,
}

This comment has been minimized.

@edmundoa

edmundoa Aug 14, 2015

Member

There is a missing semicolon here.

@dennisoelkers dennisoelkers force-pushed the stream-or-operator-ui branch from 9f5de9f to fcd5e97 Aug 14, 2015

@dennisoelkers dennisoelkers force-pushed the stream-or-operator-ui branch from fcd5e97 to 0a2eb86 Aug 14, 2015

@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 14, 2015

LGTM 👍

edmundoa added a commit that referenced this pull request Aug 14, 2015

Merge pull request #1552 from Graylog2/stream-or-operator-ui
Feature: Stream OR-Operator UI

@edmundoa edmundoa merged commit 0dc3cb4 into master Aug 14, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the stream-or-operator-ui branch Aug 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment