Skip to content
This repository has been archived by the owner. It is now read-only.

Feature: Stream OR-Operator UI #1552

Merged
merged 6 commits into from Aug 14, 2015
Merged

Feature: Stream OR-Operator UI #1552

merged 6 commits into from Aug 14, 2015

Conversation

@dennisoelkers
Copy link
Contributor

@dennisoelkers dennisoelkers commented Aug 11, 2015

This PR adds a simple UI for the matching type of stream. Configuration is done inline in the stream rules editor by adding a simple dropdown in a verbal description of the matching logic. In the streams list, the stream type is indicated in the verbal description of the stream rules summary.

@edmundoa edmundoa self-assigned this Aug 11, 2015
@edmundoa edmundoa added this to the 1.2.0 milestone Aug 11, 2015
static propTypes = {
stream: PropTypes.object.isRequired,
onChange: PropTypes.func.isRequired,
}
Copy link
Member

@edmundoa edmundoa Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing semicolon here.

Loading

@dennisoelkers dennisoelkers force-pushed the stream-or-operator-ui branch from 9f5de9f to fcd5e97 Aug 14, 2015
@dennisoelkers dennisoelkers force-pushed the stream-or-operator-ui branch from fcd5e97 to 0a2eb86 Aug 14, 2015
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Aug 14, 2015

LGTM 👍

Loading

edmundoa added a commit that referenced this issue Aug 14, 2015
@edmundoa edmundoa merged commit 0dc3cb4 into master Aug 14, 2015
2 checks passed
Loading
@edmundoa edmundoa deleted the stream-or-operator-ui branch Aug 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants