Skip to content
This repository has been archived by the owner. It is now read-only.

Add support for JSON extractor #1555

Merged
merged 1 commit into from Aug 21, 2015
Merged

Add support for JSON extractor #1555

merged 1 commit into from Aug 21, 2015

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Aug 14, 2015

@joschi joschi added this to the 1.2.0 milestone Aug 14, 2015
@joschi joschi force-pushed the server-issue-632 branch from 0d1a3fd to c54fb63 Aug 14, 2015
@edmundoa edmundoa self-assigned this Aug 19, 2015

<input type="hidden" name="extractor_type" value="json" />
<div class="form-group">
<label for="flatten">Flatten structures</label>

This comment has been minimized.

@edmundoa

edmundoa Aug 19, 2015
Member

This checkbox looks weird, I would use something like this instead:

<div class="row">
    <div class="col-md-12">
        <div class="checkbox">
            <label>
                <input name="flatten" id="flatten" type="checkbox" value="flatten" @if(flatten) { checked="checked" } />
                Flatten structures
            </label>
        </div>
        <span class="help-block">
            Whether to flatten JSON objects into a single message field or to expand into multiple fields.
        </span>
    </div>
</div>
</span>
</div>

<button class="btn btn-info xtrc-try-json" type="button">Try!</button>

This comment has been minimized.

@edmundoa

edmundoa Aug 19, 2015
Member

The try button doesn't work, I think there's some javascript missing. I think you will be happy to look into extractors.js. Or maybe not.

This comment has been minimized.

@joschi

joschi Aug 19, 2015
Author Contributor

computering

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Aug 19, 2015

Other than the inline issues, we are also missing a link to the new extractor on the search result page, specifically in javascript/src/components/search/MessageFieldDescription.jsx.

Jochen Schalanda
@joschi joschi force-pushed the server-issue-632 branch from c54fb63 to 2685a7b Aug 19, 2015
@joschi
Copy link
Contributor Author

@joschi joschi commented Aug 19, 2015

Other than the inline issues, we are also missing a link to the new extractor on the search result page, specifically in javascript/src/components/search/MessageFieldDescription.jsx.

I didn't even know we had this feature…
¯_(ツ)_/¯

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Aug 21, 2015

Looking good now! :shipit:

edmundoa added a commit that referenced this pull request Aug 21, 2015
Add support for JSON extractor
@edmundoa edmundoa merged commit 20abae1 into master Aug 21, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@edmundoa edmundoa deleted the server-issue-632 branch Aug 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.