New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling on dashboard widgets #1590

Merged
merged 2 commits into from Sep 2, 2015

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Sep 2, 2015

  • Show N/A or the last calculated value when a widget value could not be loaded
  • Get a more specific error from the REST API call if available

This PR fixes #1589.

edmundoa added some commits Sep 2, 2015

Stop spinner when widget value cannot be loaded
- When a value was already present, show the previous value
- When a value was not present, show "N/A"

In any case, we show a warning icon with the error from the AJAX call.

Refs #1589
Show specific error message on widget failure
When widget value cannot be calculated, show a more specific error
message if available on the widget warning icon.

Refs #1589

@edmundoa edmundoa added this to the 1.2.0 milestone Sep 2, 2015

kroepke added a commit that referenced this pull request Sep 2, 2015

Merge pull request #1590 from Graylog2/issue-1589
Improve error handling on dashboard widgets

@kroepke kroepke merged commit 6eab898 into 1.2 Sep 2, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kroepke kroepke deleted the issue-1589 branch Sep 2, 2015

@kroepke

This comment has been minimized.

Contributor

kroepke commented Sep 2, 2015

Can we return more HTML next time? 😢

@edmundoa

This comment has been minimized.

Member

edmundoa commented Sep 2, 2015

<html>
  <body>
    <div>lass mich in ruhe</div>
  </body>
</html>

You asked for it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment