Skip to content
This repository has been archived by the owner. It is now read-only.

Improve error handling on dashboard widgets #1590

Merged
merged 2 commits into from Sep 2, 2015
Merged

Improve error handling on dashboard widgets #1590

merged 2 commits into from Sep 2, 2015

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Sep 2, 2015

  • Show N/A or the last calculated value when a widget value could not be loaded
  • Get a more specific error from the REST API call if available

This PR fixes #1589.

edmundoa added 2 commits Sep 2, 2015
- When a value was already present, show the previous value
- When a value was not present, show "N/A"

In any case, we show a warning icon with the error from the AJAX call.

Refs #1589
When widget value cannot be calculated, show a more specific error
message if available on the widget warning icon.

Refs #1589
@edmundoa edmundoa added this to the 1.2.0 milestone Sep 2, 2015
kroepke added a commit that referenced this issue Sep 2, 2015
Improve error handling on dashboard widgets
@kroepke kroepke merged commit 6eab898 into 1.2 Sep 2, 2015
2 checks passed
@kroepke kroepke deleted the issue-1589 branch Sep 2, 2015
@kroepke
Copy link
Contributor

@kroepke kroepke commented Sep 2, 2015

Can we return more HTML next time? 😢

@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Sep 2, 2015

<html>
  <body>
    <div>lass mich in ruhe</div>
  </body>
</html>

You asked for it 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants