New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sane information about the index ranges on System/Indices #1593

Merged
merged 2 commits into from Sep 3, 2015

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Sep 3, 2015

Instead of using the "dummy" index range of the current deflector target, the index overview now shows the actual number of messages in the current deflector target and "now" as message date.

Show sane information about the index ranges on System/Indices
Instead of using the "dummy" index range of the current deflector target,
the index overview now shows the actual number of messages in the current
deflector target and "now" as message date.

@joschi joschi added this to the 1.2.0 milestone Sep 3, 2015

@edmundoa edmundoa self-assigned this Sep 3, 2015

Contains messages up to @DateHelper.readablePeriodFromNow(index.getRange.getEnd)
} else {
Contains messages from @DateHelper.readablePeriodFromNow(index.getRange.getBegin) up to @DateHelper.readablePeriodFromNow(index.getRange.getEnd)
@if(index.getName.equals(deflectorTarget) && index.getInfo != null) {

This comment has been minimized.

@edmundoa

edmundoa Sep 3, 2015

Member

This branch will never be called (the index will never be a deflector at that point), and is also redundant, the size is also rendered afterwards.

This comment has been minimized.

@joschi

joschi Sep 3, 2015

Contributor

Mild shock

@edmundoa

This comment has been minimized.

Member

edmundoa commented Sep 3, 2015

This also fixes #1127.

@edmundoa

This comment has been minimized.

Member

edmundoa commented Sep 3, 2015

LGTM 👍

edmundoa added a commit that referenced this pull request Sep 3, 2015

Merge pull request #1593 from Graylog2/index-overview
Show sane information about the index ranges on System/Indices

@edmundoa edmundoa merged commit 307affb into 1.2 Sep 3, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@edmundoa edmundoa deleted the index-overview branch Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment