New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back button behaviour #1594

Merged
merged 1 commit into from Sep 7, 2015

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Sep 3, 2015

When performing searches, keep only a single item in the browser history per page load. That is achieved by using window.location.replace instead of window.location.hash.

Also fix problems with back button on the sources tab. We need to change how the SearchStore interacts with the URL in there, but that is a story for another day :)

Fixes #1404.

Fix back button behaviour
When performing searches, keep only a single item in the browser history
per page load. That is achieved by using `window.location.replace`
instead of `window.location.hash`.

Also fix problems with back button on the sources tab.

Fixes #1404

@edmundoa edmundoa added this to the 1.2.0 milestone Sep 3, 2015

@bernd bernd self-assigned this Sep 7, 2015

@bernd

This comment has been minimized.

Contributor

bernd commented Sep 7, 2015

LGTM 👍

bernd added a commit that referenced this pull request Sep 7, 2015

Merge pull request #1594 from Graylog2/issue-1404
Fix back button behaviour

@bernd bernd merged commit e15b631 into 1.2 Sep 7, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the issue-1404 branch Sep 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment