Permalink
Switch branches/tags
Nothing to show
Commits on Apr 23, 2014
  1. bugfix: add accept amount to balance after expiration when sell is ca…

    grazcoin committed Apr 23, 2014
    …ncelled
    
    now we have consensus again :)
Commits on Apr 22, 2014
Commits on Apr 21, 2014
  1. bugfix: accept payment after sell cancel with following new sell

    grazcoin committed Apr 21, 2014
    The following steps introduced a bug:
    1. sell offer accepted
    2. sell offer cancelled
    3. sell accept paid within allowed time after sell cancel
    4. new sell offer on thie same address
    
    The reserved amount was temporarly negative, and non zero reserved
    was treated as an open sell offer. This fact invalidated the next
    new sell offer on the same address.
    
    The relevant parsing/validating path got fixed, but the invalid
    transaction stays invalid so we don't change history:
    https://masterchain.info/selloffer.html?tx=13fb62038d98ca4680c6295ba10d17b63c050ccde9c4cee7579fd2e148f25581&currency=MSC
    The accepts of the invalidated sell offer get also invalidated:
    https://masterchain.info/sellaccept.html?tx=8593540888247a9772fbe0fbcdd765df179779ae0c728e1fe83051f1bf0efe2f&currency=MSC
    https://masterchain.info/sellaccept.html?tx=67d6302a45380289de0097afdae8d21a84b0a41221ca14319b3e4cdd8952a53b&currency=MSC
Commits on Mar 28, 2014
Commits on Mar 27, 2014
  1. bugfix: correct expiration of multiple accept offers that expire on a…

    grazcoin committed Mar 23, 2014
    … single block
    
    The mechanism that checks expiration of accept offers uses a dictionary
    for alarms which contains expration block number as a key and a list of accept txid
    that expire at that block.
    While iterating on the list, the code removed checked accept txid from that list
    In a case where multiple accept transactions expire in a single block, this removal
    causes the second accept expiration to be skipped.
    specifically, this unpaid accept offer was hanging in a non expired state:
    https://masterchain.info/sellaccept.html?tx=5737353a669583964a296ef920837fd97ad5c89c3dee9e8216e674dad5c76c6e&currency=MSC
    avoiding the removal of old alerts from this dictionary fixes the problem
    
    This is the only case that such a problem has happened.
    The effect was a wrong calculation of the following accept offer (missing 1.3 MSC):
    https://masterchain.info/sellaccept.html?tx=d846fd98dcd268f835d272e13b8623fd2ca435060fa91baaf8426bffb067a5b1&currency=MSC
    but since we could see that the later payment was correct, and the consensus support it,
    I see no problem to correct this problem retrospective.
    
    If the foundation insists, I could still keep the bug until current block.
  2. invalidate tx with multiple outputs to exodus

    grazcoin committed Mar 20, 2014
    if a transaction does not originate from exodus, do not
    allow multiple outputs to exodus
    
    example:
    https://masterchain.info/simplesend.html?tx=f1a0f43f10c3af7eff7b998ef0eb82f0eb82698f3752b27486e5537895207d51
    has 2 outputs of 5460 satoshi to exodus
  3. allow case of different reserved funds and accepted on sell offer update

    grazcoin committed Mar 16, 2014
    Such a case may be caused by a bug, but in some cases it is a normal behavior
    the trigger for this change is:
    https://masterchain.info/selloffer.html?tx=b4fff0b33a547078cbde9a824a71a1d1ecdc6d234c0a2ac5df9123e129fa44a1&currency=MSC
    Although transaction got parsed well, the automatic bug alert mechanism prevented
    the sell offer from being attached to the seller address, and therefore it was
    not available on the user interface, and the reserved funds did not get update.
    Any user could have accepted this sell offer if they visited the sell offer
    page directly.
  4. invalidate tx with empty from address

    grazcoin committed Mar 16, 2014
    examle transaction:
    8fba98bc4ec872e8529433d70f1ac4f2724e0f42513214851b8155fa17522e3e
    where the input is a multisig address
  5. add amount bought to bitcoin payment parsing

    grazcoin committed Mar 9, 2014
    show on btcpayment view
    
    Conflicts:
    	www/btcpayment.html
  6. fix reversed sell offer order on bitcoin payment

    grazcoin committed Mar 4, 2014
    it caused under certain conditions to a mismatch of accept and sell orders
  7. update reserved funds of old sell offer when accept expires

    grazcoin committed Mar 3, 2014
    if sell offer got updated during a running accept against an old sell offer,
    drop the reserved funds due to that accept when it expires
    
    discussed on:
    https://bitcointalk.org/index.php?topic=292628.msg5487346#msg5487346
  8. remove apps directory

    grazcoin committed Mar 27, 2014
Commits on Mar 26, 2014
  1. add fix

    khan-faiz authored and grazcoin committed Mar 19, 2014
  2. made some debug output in validation not kill everything if one of it…

    Curtis Lacy authored and grazcoin committed Mar 16, 2014
    …s arguments is not a string.
  3. Revert "rename the orig bootstrap tx directory"

    Curtis Lacy authored and grazcoin committed Feb 11, 2014
    instead of:
    curtislacy@72f8507
    
    This reverts commit b11f93a.
  4. Changes the output of msc_validate to rename the sell offer files

    maddenpj authored and grazcoin committed Jan 28, 2014
    Conflicts:
    	msc_cron.sh
    	msc_validate.py
  5. Added the optional tools path to calls to get_revision_dict.

    Curtis Lacy authored and grazcoin committed Jan 23, 2014
  6. Add a command line argument which lets us specify the location of the…

    Curtis Lacy authored and grazcoin committed Jan 23, 2014
    … mastercoin-tools repository.
  7. Revert "set mastercoin_tools_dir on msc_globals"

    grazcoin committed Mar 26, 2014
    This reverts commit e12367f.
Commits on Mar 2, 2014
  1. remove left overs of the wallet

    grazcoin committed Mar 2, 2014
    automatic html generator
  2. set mastercoin_tools_dir on msc_globals

    grazcoin committed Mar 2, 2014
    default on globals is '~/mastercoin-tools'
    the cron script can be also updated by setting MASTERCOIN_TOOLS_DIR