Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sound absent #27

Closed
imdopey opened this issue May 15, 2019 · 3 comments · Fixed by #32
Closed

Sound absent #27

imdopey opened this issue May 15, 2019 · 3 comments · Fixed by #32
Assignees
@tomaski
Labels
pending release Scheduled for upcoming update
Milestone
5.0.7

Comments

@imdopey
Copy link

imdopey commented May 15, 2019

Description

Whenever i get attacked the custom sound doesn't play. Even trying to test the sound function doesn't give anything. I made sure the sound was OK since the normal since i attacked myself without add on and grepolis sound on.

How to reproduce the problem

  • Get attacked
  • No sound comes out
  • Go to settings and test a new sound
  • No sound comes out

Expected behavior

When i get attacked it should play the custom set sound which was provided via a Youtube link.

Actual behavior

It gives a notification that its playing the sound.. however it emits nothing.

How often

Always; tested on 2 worlds

Additional information

  • Script version: [5.0.6]
  • Operating system: [Win 10]
  • Used webbrowser: [Chrome]
@tomaski tomaski added the needs analysis Closer look required label May 15, 2019
@tomaski tomaski added this to the 5.0.7 milestone May 15, 2019
@tomaski
Copy link
Member

tomaski commented May 15, 2019

Hi @imdopey ! thank you for taking time to report this issue. We'll go and check it out

@tomaski tomaski self-assigned this May 15, 2019
@tomaski tomaski added pending release Scheduled for upcoming update and removed needs analysis Closer look required labels May 16, 2019
@imdopey
Copy link
Author

imdopey commented May 16, 2019

thanks for taking the time; i really appreciate the function and work put into the tool :D

Potusek added a commit that referenced this issue May 20, 2019
@Potusek
fix(alarm): workaround for CORS with YouTube
358b259 
Youtube API started blocking CORS requests so workaround was needed to keep the custom alarms working.

Closes #27
Potusek added a commit that referenced this issue May 20, 2019
@Potusek
fix(alarm): YouTube audio didn't work
a57b2a1 
The new version of the Youtube API required different audio support.

Closes #27
Potusek added a commit that referenced this issue May 20, 2019
@Potusek
fix(alarm): YouTube audio didn't work
8802bfe 
The new version of the Youtube API required different audio support.

Closes #27
tomaski added a commit that referenced this issue May 20, 2019
@tomaski
fix(alarm): workaround for CORS with YouTube
5ebe71e 
Youtube API started blocking CORS requests so workaround was needed to keep the custom alarms working.

Closes #27
tomaski added a commit that referenced this issue May 20, 2019
@tomaski
fix(alarm): workaround for CORS with YouTube
2413414 
Youtube API started blocking CORS requests so workaround was needed to keep the custom alarms working.

Closes #27
@tomaski tomaski mentioned this issue May 21, 2019
Closed
5 tasks
Potusek added a commit that referenced this issue May 21, 2019
@Potusek
fix(alarm): YouTube audio didn't work
00a438e 
The new version of the Youtube API required different audio support.

Closes #27
@Potusek Potusek mentioned this issue May 21, 2019
Merged
5 tasks
tomaski pushed a commit that referenced this issue May 21, 2019
@Potusek @tomaski
fix(alarm): YouTube audio didn't work (#32)
1be5d40 
fix(alarm): YouTube audio didn't work

The new version of the Youtube API required different audio support.

Closes #27
tomaski pushed a commit that referenced this issue May 21, 2019
@semantic-release-bot
chore(release): 5.0.7 [skip ci]
2760d2f 
## [5.0.7](v5.0.6...v5.0.7) (2019-05-21)

### Bug Fixes

* **alarm:** YouTube audio didn't work ([#32](#32)) ([1be5d40](1be5d40)), closes [#27](#27)
@tomaski
Copy link
Member

tomaski commented May 21, 2019

🎉 This issue has been resolved in version 5.0.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaski tomaski

Labels
pending release Scheduled for upcoming update
Projects
None yet
Milestone
5.0.7
2 participants
@tomaski @imdopey