@icon failures should be warnings, not fatal errors #1214

Closed
arantius opened this Issue Nov 4, 2010 · 1 comment

Projects

None yet

1 participant

@arantius
Collaborator

@icon support as of #1096 works consistently and well, but whenver there is an error (e.g. downloading the URL @icon references) it is a completely fatal error -- a modal alert() blocks, and the script does not install.

Instead, the error should be logged to the Error Console, and the script should continue to install, simply without an icon.

@arantius
Collaborator

Test case: https://gist.github.com/1072748

The first version, a nonexistent host, works. The second, pointing at localhost (where I do have a web server, but not an "error.png" in the root) fails.

@arantius arantius added a commit that closed this issue Jul 9, 2011
@arantius arantius Ignore failed icon downloads.
Fixes #1214
674a51d
@arantius arantius closed this in 674a51d Jul 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment