Join GitHub today
Issue when closing sidebar (ex bookmarks) #1298
Browser: Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110301 Firefox/4.0b13pre ID:20110301030403
I have verified this happens with greasemonkey
Steps to reproduce:
At least I've got a reduced test case: https://gist.github.com/920262
Since #1038 / 1f0efae we've allowed injection into about:blank. This might be a bad idea. In this case I believe it's causing infinite recursion: Script loads in a page, creates a frame (no src, so about:blank) which causes a(n empty) document to load, which the script runs in, where it creates a frame, which ..
It must be the case that the top-level node (with src=about:blank?) is considered part of chrome and doesn't get this limit. There's also a maximum nesting (regardless of URL) limit of 10, but it's specifically called "MAX_DEPTH_CONTENT_FRAMES" -- if the browser doesn't think that it's content, it's probably not applying this limit.
Mayhaps we should stop injecting into about:blank?
I would perhaps go one further and deprecate
If instead you do wish to include it everywhere, you must explicitly specify the protocols you wish it to apply to:
I'd suggest that this adds clarity for free too - it doesn't apply so much with the
Too many assumptions - you're assuming that @include is understood as referring to the urls that the script runs on and you're assuming that * will instantly be recognised as a wildcard.
I don't dispute that given a push the meaning of