FF4: Add-ons manager update breaks sort #1307

Closed
arantius opened this Issue Mar 13, 2011 · 7 comments

Projects

None yet

3 participants

@arantius
Collaborator

After the fix for #1305, with anything besides the default sort order selected, the default (status) sort is re-applied when the change is displayed.

@sizzlemctwizzle

Hey can you label this 0.9.2?

@arantius
Collaborator

Hey can you label this 0.9.2?

Do you have a fix ready? I want to get 0.9.2 out because it's got some other important bug fixes, and this is relatively minor.

@sizzlemctwizzle

Do you have a fix ready?
Not yet.
I want to get 0.9.2 out because it's got some other important bug fixes, and this is relatively minor.
I wasn't sure how soon you were planning the release. Yeah there's no need to wait for this.

@arantius
Collaborator

Confirmed on Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0) Gecko/20100101 Firefox/4.0, GM head.

The last-clicked sort button still shows its active status, but the contents re-sort to the default.

@qufighter

It's unfortunate that current selection and scroll position are lost when clicking back button, this effects the extensions list too? It's not behaving very much like a back button.

@arantius arantius added a commit to arantius/greasemonkey that referenced this issue Apr 20, 2011
@arantius arantius Use existing 'ViewChanged' listener.
Fixes #1307
7f7848a
@arantius arantius added a commit that closed this issue Apr 20, 2011
@sizzlemctwizzle sizzlemctwizzle When the script list is reloaded in the Addons manager due to some ch…
…ange to the Addon objects, resort the list of scripts according to the currently selected sort criteria. Closes #1307
109b93c
@arantius arantius closed this in 109b93c Apr 20, 2011
@arantius arantius added a commit to arantius/greasemonkey that referenced this issue Apr 28, 2011
@arantius arantius Rewrite such that addons4 update never breaks sort.
Fixes #1307
b4b3dbd
@arantius
Collaborator

Whoops sorry, that commit just now was to fix #1331 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment