Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

0.9.4: Cannot enable nor disable scripts #1355

Closed
Martii opened this Issue May 26, 2011 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

Martii commented May 26, 2011

Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1  Clean Profile
Greasemonkey 0.9.4

Open Firefox in new profile
Install add-on from AMO or use ./build.sh on current GM HEAD (should match as of right now)
Restart
Install any script
Open AOM in new tab
Click Disable... nothing happens visually
Click Remove... nothing happens visually
Navigate to page that injects script.
Primary click monkey menu arrow
Attempt to primary click disable script.... nothing visually happens

Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1  Dirty Profile
Greasemonkey 0.9.4

Install add-on from AMO or use ./build.sh on current GM HEAD (should match as of right now)
Restart Firefox
Open AOM
Click Disable... nothing happens visually
Click Remove... nothing happens visually
Navigate to page that injects script.
Primary click monkey menu arrow
Attempt to primary click disable script.... nothing visually happens

Contributor

Martii commented May 26, 2011

Error Console output for AOM Disable click event and Monkey Menu click event

Error: enabled is not defined
Source File: chrome://greasemonkey/content/script.js
Line: 90
Contributor

Martii commented May 26, 2011

Most probable fix is:

Script.prototype.__defineSetter__('enabled',
function Script_setEnabled(enabled) {
  this._enabled = enabled;
  this._changed("edit-enabled", enabled);
});
Contributor

Martii commented May 26, 2011

Collaborator

arantius commented May 26, 2011

Edited the title to be more concise, patch accepted.

@arantius arantius closed this in 68cb0eb May 26, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment