Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

0.9.4: Cannot enable nor disable scripts #1355

Closed
Martii opened this Issue · 4 comments

2 participants

@Martii
Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1  Clean Profile
Greasemonkey 0.9.4

Open Firefox in new profile
Install add-on from AMO or use ./build.sh on current GM HEAD (should match as of right now)
Restart
Install any script
Open AOM in new tab
Click Disable... nothing happens visually
Click Remove... nothing happens visually
Navigate to page that injects script.
Primary click monkey menu arrow
Attempt to primary click disable script.... nothing visually happens

Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1  Dirty Profile
Greasemonkey 0.9.4

Install add-on from AMO or use ./build.sh on current GM HEAD (should match as of right now)
Restart Firefox
Open AOM
Click Disable... nothing happens visually
Click Remove... nothing happens visually
Navigate to page that injects script.
Primary click monkey menu arrow
Attempt to primary click disable script.... nothing visually happens

@Martii

Error Console output for AOM Disable click event and Monkey Menu click event

Error: enabled is not defined
Source File: chrome://greasemonkey/content/script.js
Line: 90
@Martii

Most probable fix is:

Script.prototype.__defineSetter__('enabled',
function Script_setEnabled(enabled) {
  this._enabled = enabled;
  this._changed("edit-enabled", enabled);
});
@Martii Martii referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@arantius
Collaborator

Edited the title to be more concise, patch accepted.

@arantius arantius closed this issue from a commit
Martii Closes #1355
Missed alias that holds the value attempted to be assigned.
68cb0eb
@arantius arantius closed this in 68cb0eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.