New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call setTimeout() with strings #1398

Closed
arantius opened this Issue Aug 19, 2011 · 0 comments

Comments

Projects
None yet
1 participant
@arantius
Copy link
Collaborator

arantius commented Aug 19, 2011

Mozilla review of 0.9.9 said:

This version didn't pass full review because of the following issues ... you need to correct them to get full approval. Thanks.

  1. Your add-on calls the setTimeout or setInterval functions with string rather than function arguments, which is normally not allowed. For instance, setTimeout('object.doStuff()') should be written as setTimeout(function () { object.doStuff() }) instead.

@arantius arantius closed this in 59d1fd6 Aug 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment