Do not call setTimeout() with strings #1398

arantius opened this Issue Aug 19, 2011 · 0 comments


None yet
1 participant

arantius commented Aug 19, 2011

Mozilla review of 0.9.9 said:

This version didn't pass full review because of the following issues ... you need to correct them to get full approval. Thanks.

  1. Your add-on calls the setTimeout or setInterval functions with string rather than function arguments, which is normally not allowed. For instance, setTimeout('object.doStuff()') should be written as setTimeout(function () { object.doStuff() }) instead.

@arantius arantius closed this in 59d1fd6 Aug 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment